Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Mar 2022 11:58:22 +0900
From:   Jung Daehwan <dh10.jung@samsung.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Howard Yen <howardyen@google.com>,
        Jack Pham <jackp@codeaurora.org>,
        Puma Hsu <pumahsu@google.com>,
        "J . Avila" <elavila@google.com>,
        "chihhao . chen" <chihhao.chen@mediatek.com>, sc.suh@samsung.com,
        cpgs@samsung.com, cpgsproxy5@samsung.com
Subject: Re: [PATCH v1 1/4] usb: host: export symbols for xhci hooks usage
Message-ID: <1983025922.01648006681661.JavaMail.epsvc@epcpadp4>
MIME-Version: 1.0
In-Reply-To: <b33d8497-d6d5-18e2-93a9-e0564a84c1c5@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: multipart/mixed;
        boundary="----.rW42XXn7_Ji6OxwuAF4RAMbP.qed.OeqKlvEhSLhB3noATS=_238f9d_"
References: <1646375038-72082-1-git-send-email-dh10.jung@samsung.com>
        <CGME20220304062617epcas2p2084161966aaa66d07f4c25720ec18088@epcas2p2.samsung.com>
        <252651381.41646375583002.JavaMail.epsvc@epcpadp4>
        <b33d8497-d6d5-18e2-93a9-e0564a84c1c5@kernel.org>
Precedence: bulk

------.rW42XXn7_Ji6OxwuAF4RAMbP.qed.OeqKlvEhSLhB3noATS=_238f9d_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Mon, Mar 07, 2022 at 10:59:06AM +0100, Krzysztof Kozlowski wrote:
> On 04/03/2022 07:23, Daehwan Jung wrote:
> > Export symbols for xhci hooks usage:
> > 	xhci_ring_free
> > 	- Allow xhci hook to free xhci_ring.
> 
> Instead of copying-pasting the name of function, please explain why do
> you need these symbols exported.
> 
> The "Why" is actually one of most important questions, because "what is
> this patch doing" we can easily see...
> 
> > 
> > 	xhci_get_slot_ctx
> > 	- Allow xhci hook to get slot_ctx from the xhci_container_ctx
> > 	  for getting the slot_ctx information to know which slot is
> > 	  offloading and compare the context in remote subsystem memory
> > 	  if needed.
> > 
> 
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof

xhci_ring_free has been removed from v3..
The reason why I want to export is for managing vendor specific ring.
I want to alloc and free vendor specific ring on specific address.
It's done with xhci hooks.

Below is the patch of v3

Export symbols for xhci hooks usage:
    xhci_get_slot_ctx
    xhci_get_endpoint_address
    - Allow xhci hook to get ep_ctx from the xhci_container_ctx for
      getting the ep_ctx information to know which ep is offloading and
      comparing the context in remote subsystem memory if needed.

    xhci_ring_alloc
    - Allow xhci hook to allocate vendor specific ring.

    xhci_trb_virt_to_dma
    - Used to retrieve the DMA address of vendor specific ring.

    xhci_segment_free
    xhci_link_segments
    - Allow xhci hook to handle vendor specific segment.

    xhci_initialize_ring_info
    - Allow xhci hook to initialize vendor specific ring.

    xhci_check_trb_in_td_math
    - Allow xhci hook to Check TRB math for validation.

    xhci_address_device
    - Allow override to give configuration info to Co-processor.

    xhci_bus_suspend
    xhci_bus_resume
    - Allow override of suspend and resume for power scenario.

    xhci_remove_stream_mapping
    - Allow xhci hook to remove stream mapping.

Best Regards,
Jung Daehwan.

------.rW42XXn7_Ji6OxwuAF4RAMbP.qed.OeqKlvEhSLhB3noATS=_238f9d_
Content-Type: text/plain; charset="utf-8"


------.rW42XXn7_Ji6OxwuAF4RAMbP.qed.OeqKlvEhSLhB3noATS=_238f9d_--