Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Mar 2022 22:53:52 +0100
From:   "Steinar H. Gunderson" <sesse@google.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] perf intel-pt: Synthesize cycle events
Message-ID: <YjpFcLiCTjHZWzzA@google.com>
References: <20220322082452.1429091-1-sesse@google.com>
 <YjpAYjdgHWwkid5N@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YjpAYjdgHWwkid5N@kernel.org>
Precedence: bulk

On Tue, Mar 22, 2022 at 06:32:18PM -0300, Arnaldo Carvalho de Melo wrote:
> I saw there was some issue, should I proceed and apply this v3 patch or
> wait for some v4?

There are two issues in play:

 1. PT event synth doesn't support reading inline information from DWARF
    yet, and my patch to add it runs into some problems. This is not
    relevant for this patch at all.
 2. The results from v3 don't quite match the ones from v1, and neither
    of us are entirely sure why. My personal feeling is that the one
    from v1 are the wrong ones, but it's up to Adrian to say whether we
    want to try to investigate deeply here.

/* Steinar */