Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220316183833.1563139-1-arnd@kernel.org> <3b9cedd6-a084-5d87-2fdd-0da10146827b@arm.com>
 <CAKwvOdnut8db1Z1FdZkkSXCvmggrzfKv9Y9GO3uz4ND=K5sB3g@mail.gmail.com>
In-Reply-To: <CAKwvOdnut8db1Z1FdZkkSXCvmggrzfKv9Y9GO3uz4ND=K5sB3g@mail.gmail.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Tue, 22 Mar 2022 10:02:23 -0700
Message-ID: <CAKwvOdkyGumBcCWwNo+yBFZ_A9OOFgVCOecOgpcfEunNRqy_+w@mail.gmail.com>
Subject: Re: [PATCH] arm64: fix clang warning about TRAMP_VALIAS
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     Arnd Bergmann <arnd@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        James Morse <james.morse@arm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 18, 2022 at 12:52 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Fri, Mar 18, 2022 at 12:11 PM Robin Murphy <robin.murphy@arm.com> wrote:
> >
> > On 2022-03-16 18:38, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > The newly introduced TRAMP_VALIAS definition causes a build warning
> > > with clang-14:
> > >
> > > arch/arm64/include/asm/vectors.h:66:31: error: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Werror,-Wnull-pointer-arithmetic]
> >
> > Tangentially, all the other GNU extensions we depend on throughout Linux
> > are also GNU extensions. Do we know what's special about this one?
>
> My first thought is that -Wnull-pointer-arithmetic should be in the
> -Wgnu flag group, such that -Wno-gnu (as set by Kbuild) implies
> -Wno-null-pointer-arithmetic.
>
> One issue seems to be that -Wnull-pointer-arithmetic seems to control
> at least 2 different checks in clang.
>
> https://godbolt.org/z/hdYYejj3d
>
> So it's likely these two checks should have 2 distinct flags, such
> that the warning we're observing can be grouped under -Wgnu.
>
> Filed: https://github.com/llvm/llvm-project/issues/54444

Fix should be landing shortly:
https://reviews.llvm.org/D122224

-- 
Thanks,
~Nick Desaulniers