Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <66a3f996-ac12-9165-93c9-e1fa93b80eed@nvidia.com>
Date:   Tue, 22 Mar 2022 23:42:35 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [Patch v5 3/4] dt-bindings: memory: Update reg maxitems for
 tegra186
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        robh+dt@kernel.org, thierry.reding@gmail.com, digetx@gmail.com,
        jonathanh@nvidia.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org
Cc:     vdumpa@nvidia.com, Snikam@nvidia.com
References: <20220316092525.4554-1-amhetre@nvidia.com>
 <20220316092525.4554-4-amhetre@nvidia.com>
 <74db8a20-7cce-ff86-7ae4-466416443ba9@canonical.com>
From:   Ashish Mhetre <amhetre@nvidia.com>
In-Reply-To: <74db8a20-7cce-ff86-7ae4-466416443ba9@canonical.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjU1N3pkNVB0NXNuUG9STVZEclVLcFZ6Ulh4aEFKOHhNL2RnUmJveEYwTTkv?=
 =?utf-8?B?OElWS0diS2NhQjJiS0JtZjkzdTJUN2RWVGpSNktYcG9lcS92WFF4UVdGSFRy?=
 =?utf-8?B?TUVaUlloMm84dDc2a0VWMVhRd2Q2SW5SeHgzZmdSZEhNRVorZzQ4KzBxeGdv?=
 =?utf-8?B?R09ieGU1eE16ZmNPdlFlVHprNFJ3TkZweXpXSkZDTThmOXhMMjVQZHpMbzV4?=
 =?utf-8?B?VHcybW1ocWZmVDdhMlQxMVFIQVVJL2hGUVdoLzJITnhkWUxNMUQzU2tkU1c3?=
 =?utf-8?B?NUlTVE5wbDJXSDdZM2VySXdySHdXOHNIR0s5ekdkZ0N6REN4dStIUTVBZjlr?=
 =?utf-8?B?Y1NqNjJoQzFNS3B4eHAwcXJaNEFZcVY0SkwwTnR4djB5SWVwR08yNHV5VWNq?=
 =?utf-8?B?ck9XUWwrOGNPVlowZEtnZy9QYnVLUnNrUE12QlVCR1ZMOXlHOTl3MXo2a3VN?=
 =?utf-8?B?Z2VaWkhoRmJRSUE3RVB0a1pEc2RCTFRXMGFDZE9BT2JQNlp6OWJ4a2NYSkpJ?=
 =?utf-8?B?SHBFY2lXNDJicjE4T1FlNmxYZ2hMZkMxWUNkWXB3dm1Kc0UwQnUyazhyeFZP?=
 =?utf-8?B?UVZBTnVvZVRrT3kySERnQ2dmaHlJbC9EMk1OSVNCYm9xR2QrdmxubzdsdDNl?=
 =?utf-8?B?S3RuMmFzaU1iY3NLYXRPVkJiUzhhNkxkQVZKRkF0bEllN3ltS09yZWowM0VB?=
 =?utf-8?B?TzVuVTJDT3Jsbi9wUUwxdkwydmFYNEo3RUt6a0ZIOG9saHp5ZzJSb0k4OGxl?=
 =?utf-8?B?V3dVQ2YvSUdVR09iWklUakxwdjlYYUNjdFdhWVdLUk9aY0tTSFJVeHdnZHlj?=
 =?utf-8?B?ck9Zc0ZBajhBUWZDdlhWazc1dFhaZlBRM0E4VGZkb1UzSktIa0NIdlhQTmM5?=
 =?utf-8?B?bzdVZ2MvY3BrNDF2cnQxNCtDbnN4WjcyVWw5NXBnTTBWZkxmdlNtOWU5eUg3?=
 =?utf-8?B?NmtrTU9DMVVSdVN5YkJFektxSGJVVUhCalQ5Zm5HQ0I2M3RWbXRvdVJ0VDND?=
 =?utf-8?B?Umo0bFY0NHRNcS9BU1FCMTRENUp6WXRyVk9veTNEQXB2OXBMa1NLcVpPa2RP?=
 =?utf-8?B?aXYrYzdSa1RMT2JYY1BycDRzZm85L1IzTWY1c25QNlZRMFVveEs4eTBhaTNa?=
 =?utf-8?B?ZEJNVzBLKzUwZFVaWklDaWdDK1c0bEFtSjh6MUY1N3k0MERVWXE2UHpjMWN2?=
 =?utf-8?B?RTVjdW5wdGlrRStyclJleTRmS0JBekduV1VqUkZTeTIvZEYvTnlYajZ6RjFG?=
 =?utf-8?B?RXhFWjNJVmhQUHFWdFRCblptTDMxUnJDOXcyY1VYaGdLVHVZN2YzYTlmU0JI?=
 =?utf-8?B?OWc1ampmTVEwN3FRV0dCUWhpRTZ6cW9TVzVGRDJpajJiN21URVZvZTRSTytv?=
 =?utf-8?B?anZHNE5ESEUxTUs5aFB4aGFrYzBMNTFNeEFsR1ZZZUNpcW4rSmZCNUhnYVF3?=
 =?utf-8?B?eXFXclVCeGNQZ3NLS3NvNXdTZU5qQnFUbjJ6cVZVc3VvRndZMDRRTlBNV0hu?=
 =?utf-8?B?S0JhZFdDcXF0czgxbWJuOTNFMkRTdUgvT2cyN3dlK3h4YkNOWWFmVFliTlFt?=
 =?utf-8?B?eVhzS1Q1ZnZ2clBVNk9JcUQ4YTh6eGY4dms3RmFSY0ZlcklhdWVkeWNCbjU5?=
 =?utf-8?B?bDRYdW1BSE9wRG9Ec2xhQXczUWhiS0gyTGk5eUoxOUNHSXVuNDdDV3VZUGxv?=
 =?utf-8?B?ck1xamI1NXFsMlhGSTBiNjNMU1RuZnlkSE5oZlZyalZjSzdueWhHbmladUVX?=
 =?utf-8?B?dGJINDZ1dTg0T2dMVWRvZVJBYUh1RkJsL09meXJzMFpJcFFma3IzeTczR3Zo?=
 =?utf-8?B?bEZVelZkdXAxYzc1U25ZQzJUYXpJQ3pna09MalJoQXdXVnZkVFZBN1gxZ2xG?=
 =?utf-8?B?dnF1alJLVjU2UDRRTGJXaGZZdnNlVkFzQnk2K1VqWUZ3MDNiWFVBTjRpTTNl?=
 =?utf-8?Q?b9aL4H2AZ0iSyIVF324oKqpAL3N6lG8J?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 993be956-02ef-458e-d71d-08da0c2f9136
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4349.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 18:12:46.9382
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tEoL0CENnbIIPoIa1VMAIQbkgobVE+Pqf1/eS/Hvzb6UF8NGdFlfXOVGNInl7+AX3eemW56jntJ2ND1pvRjgfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5171
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/20/2022 6:12 PM, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 16/03/2022 10:25, Ashish Mhetre wrote:
>>  From tegra186 onwards, memory controller support multiple channels.
>> Reg items are updated with address and size of these channels.
>> Tegra186 has overall 5 memory controller channels. Tegra194 and tegra234
>> have overall 17 memory controller channels each.
>> There is 1 reg item for memory controller stream-id registers.
>> So update the reg maxItems to 18 in tegra186 devicetree documentation.
>>
>> Signed-off-by: Ashish Mhetre <amhetre@nvidia.com>
>> ---
>>   .../nvidia,tegra186-mc.yaml                   | 20 +++++++++++++------
>>   1 file changed, 14 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
>> index 13c4c82fd0d3..3c4e231dc1de 100644
>> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
>> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
>> @@ -34,8 +34,8 @@ properties:
>>             - nvidia,tegra234-mc
>>
>>     reg:
>> -    minItems: 1
>> -    maxItems: 3
>> +    minItems: 6
>> +    maxItems: 18
> 
> Still ABI break and now the in-kernel DTS will report dt check errors.
> 
The dt check error is because I mistakenly updated example in EMC node
instead of MC. I'll fix it in next version.

> I think you ignored the comments you got about breaking ABI.
> 
No, I took care of the ABI break in v5. I have updated details about
how we took care of it in first patch.

> Best regards,
> Krzysztof