Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Mar 2022 19:48:58 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Robert Marko <robert.marko@sartura.hr>
Cc:     andrew@lunn.ch, gregory.clement@bootlin.com,
        sebastian.hesselbarth@gmail.com, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, marek.behun@nic.cz
Subject: Re: [PATCH v2 2/2] arm64: dts: uDPU: correct temperature sensors
Message-ID: <20220322184858.irr5p75tdu4mths3@pali>
References: <20220322105857.1107016-1-robert.marko@sartura.hr>
 <20220322105857.1107016-2-robert.marko@sartura.hr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220322105857.1107016-2-robert.marko@sartura.hr>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Tuesday 22 March 2022 11:58:57 Robert Marko wrote:
> uDPU has a pair of NCT375 temperature sensors, which are TMP75C compatible
> as far as the driver is concerned.
> 
> The current LM75 compatible worked as all of the LM75 compatible sensors
> are backwards compatible with the original part, but it meant that lower
> resolution and incorrect sample rate was being used.
> 
> The "lm75" compatible has been deprecated anyway and is meant as fallback
> in order to keep older DTS-es working.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Reviewed-by: Pali Rohár <pali@kernel.org>

> ---
> Changes in v2:
> * None
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> index ac64949bb53e..1f534c0c65f7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> @@ -153,15 +153,15 @@ &i2c1 {
>  	scl-gpios = <&gpionb 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  	sda-gpios = <&gpionb 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  
> -	lm75@48 {
> +	nct375@48 {
>  		status = "okay";
> -		compatible = "lm75";
> +		compatible = "ti,tmp75c";
>  		reg = <0x48>;
>  	};
>  
> -	lm75@49 {
> +	nct375@49 {
>  		status = "okay";
> -		compatible = "lm75";
> +		compatible = "ti,tmp75c";
>  		reg = <0x49>;
>  	};
>  };
> -- 
> 2.35.1
>