Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3835310pxp; Wed, 23 Mar 2022 06:43:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJza0/3eoLbBZzf2sKBSQY+wAuqGF+7OwICmG2En71p7m1oKe7jIQ2VQBrUp4z64KFeexMT4 X-Received: by 2002:aa7:cd7a:0:b0:419:48ce:3a10 with SMTP id ca26-20020aa7cd7a000000b0041948ce3a10mr119597edb.312.1648043034124; Wed, 23 Mar 2022 06:43:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648043034; cv=none; d=google.com; s=arc-20160816; b=h1AtazI1dcS2n2HgxGYlRW8w7Ug712nnmorfX0Gz7s/ibTOIKYyGjH1rbmtxdp9MIZ Zf8/tA2DyENvo888LgICTR69HjD+X74RUof9PACOH5CSJruJPH+78Vp9m7HjnpXSEIEw xH668wtd9Lb7L052h6yvOCHHUMSe8dj1HwkfAB8UpTlly+91rcF7Fm97Lr51AsuQWKKy lizQBe+DK191xfYcIw0gKhCDrQ9nZJappzbvMcge/m/JIbdkP7wcho9bF/Bg0rOrUDqw o9ijzS8S7r/5z/WJspe0LTff6fvTrkGGfc9WqkXWwzZQgNzq6EvJTGNjlqTjuZKfsHO1 Nruw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IL1DTXQ5PLoYDtzOHs2rZCCbl2DebPhnoyDqu6ydMA8=; b=lPujxL6vS+mdNW+xNoTOFlNc8CQ8//QMTR/ObiSIBsLFWVOHT/MY+/52/fDzLcmhMn Z36Bd2DEdJ4uu0CEtEA+aACfwYDVhEFwPggnu9V39W8kBn2+gKPU2bUWvV0o/0BxwEdG 1/ZPcb770/yMQ4O1AwoIw5s7w6dDtp0KJ5qvaOJN/Qar6zkk+iMQy/07X8Kzc3jttIYX f6Ftz44/ihyQNmz2salZFz/xY59TLuwamEGAY8doHBwshHtWhOPd14Z+QRf4T3tsQw5d htH8YUehxNGHG9/n0/VQh8CWlO1y+kw75E+9Up5YM3W9kuDw+VJDeGXFjx1Aus0HN9vr Z5Ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=pvTTIq3v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020a50d4c4000000b00418c2b5be57si14448576edj.313.2022.03.23.06.43.27; Wed, 23 Mar 2022 06:43:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=pvTTIq3v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240427AbiCWHfD (ORCPT + 99 others); Wed, 23 Mar 2022 03:35:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237989AbiCWHfB (ORCPT ); Wed, 23 Mar 2022 03:35:01 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5009C28E05 for ; Wed, 23 Mar 2022 00:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IL1DTXQ5PLoYDtzOHs2rZCCbl2DebPhnoyDqu6ydMA8=; b=pvTTIq3vz9PCfsGVX4JxViANnB Y2YljE0qJSg5q7PdfzAsI6zEB1NELwqox4PWgEe4k3nyAFrGZ0XU+tWpyCsaWHhz4X2egueJxUbI/ JD9EJSwKZYTBtdgbwK551Bz55MjQmXwcgYEQ2IgI55anLvcR1ESjk4gttuPZl9NbNAD5unn85kGPB o45UVIj5pBYktS2mbU5VGdKHgnnRYK1ztvZsRwxiZ80GciDqwMsICKUBoGjyCr/YaI8118csap9Wm ev8jYlgQDWtgKU/xdpyOmiZOUqzEN4FeI5r0P4CdW99nG+DQqzYCcRQDuyYctVEt9wXTfcwB3qUYy rKjbVFSQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWvUk-00D0Ka-5z; Wed, 23 Mar 2022 07:33:26 +0000 Date: Wed, 23 Mar 2022 00:33:26 -0700 From: Christoph Hellwig To: Linus Torvalds Cc: Jaegeuk Kim , Waiman Long , Linux Kernel Mailing List , Linux F2FS Dev Mailing List , Peter Zijlstra Subject: Re: [GIT PULL] f2fs for 5.18 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 22, 2022 at 10:22:50AM -0700, Linus Torvalds wrote: > On Mon, Mar 21, 2022 at 1:39 PM Jaegeuk Kim wrote: > > > > In this cycle, f2fs has some performance improvements for Android workloads such > > as using read-unfair rwsems [...] > > I've pulled this, but that read-unfair rwsem code looks incredibly > dodgy. Doing your own locking is always a bad sign, and it ahs > traditionally come back to bite us pretty much every time. At least it > uses real lock primitives, just in a really odd way. FYI, Peter and I both pointed this out when the patches were posted and NAKed the patch, but the feedback was ignored.