Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8ef010a1-d28a-a9f0-78cc-1ad8c40cfb59@infradead.org>
Date:   Tue, 22 Mar 2022 08:39:00 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [GIT PULL] scheduler updates for v5.18
Content-Language: en-US
To:     Nathan Chancellor <nathan@kernel.org>,
        Ingo Molnar <mingo@kernel.org>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>
References: <YjhZUezhnamHAl0H@gmail.com>
 <YjiddAnoCCz7Tbt3@dev-arch.thelio-3990X> <YjmAzX9kSeSjumKd@gmail.com>
 <YjnsJkUl5mO22mzg@dev-arch.thelio-3990X>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <YjnsJkUl5mO22mzg@dev-arch.thelio-3990X>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/22/22 08:32, Nathan Chancellor wrote:
> On Tue, Mar 22, 2022 at 08:54:53AM +0100, Ingo Molnar wrote:
>>
>> * Nathan Chancellor <nathan@kernel.org> wrote:
>>
>>> Hi Ingo,
>>>
>>> On Mon, Mar 21, 2022 at 11:54:09AM +0100, Ingo Molnar wrote:
>>>> Ingo Molnar (17):
>>>>       sched/headers: Fix header to build standalone: <linux/sched_clock.h>
>>>>       sched/headers: Add header guard to kernel/sched/sched.h
>>>>       sched/headers: Add header guard to kernel/sched/stats.h and kernel/sched/autogroup.h
>>>>       sched/headers: sched/clock: Mark all functions 'notrace', remove CC_FLAGS_FTRACE build asymmetry
>>>>       sched/headers: Add initial new headers as identity mappings
>>>>       sched/headers: Fix comment typo in kernel/sched/cpudeadline.c
>>>>       sched/headers: Make the <linux/sched/deadline.h> header build standalone
>>>>       sched/headers: Introduce kernel/sched/build_utility.c and build multiple .c files there
>>>>       sched/headers: Introduce kernel/sched/build_policy.c and build multiple .c files there
>>>>       sched/headers: Standardize kernel/sched/sched.h header dependencies
>>>>       sched/headers: Reorganize, clean up and optimize kernel/sched/core.c dependencies
>>>>       sched/headers: Reorganize, clean up and optimize kernel/sched/fair.c dependencies
>>>>       sched/headers: Reorganize, clean up and optimize kernel/sched/build_policy.c dependencies
>>>>       sched/headers: Reorganize, clean up and optimize kernel/sched/build_utility.c dependencies
>>>>       sched/headers: Reorganize, clean up and optimize kernel/sched/sched.h dependencies
>>>>       sched/headers: Only include <linux/entry-common.h> when CONFIG_GENERIC_ENTRY=y
>>>>       headers/prep: Fix header to build standalone: <linux/psi.h>
>>>
>>> This series regresses ARCH=arm allmodconfig:
>>>
>>> $ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- mrproper allmodconfig kernel/sched/
>>> In file included from kernel/sched/fair.c:52:
>>> kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
>>>    87 | # include <asm/paravirt_api_clock.h>
>>>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>> compilation terminated.
>>> make[3]: *** [scripts/Makefile.build:288: kernel/sched/fair.o] Error 1
>>> In file included from kernel/sched/core.c:81:
>>> kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
>>>    87 | # include <asm/paravirt_api_clock.h>
>>>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>> compilation terminated.
>>> make[3]: *** [scripts/Makefile.build:288: kernel/sched/core.o] Error 1
>>> In file included from kernel/sched/build_policy.c:33:
>>> kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
>>>    87 | # include <asm/paravirt_api_clock.h>
>>>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>> compilation terminated.
>>> make[3]: *** [scripts/Makefile.build:288: kernel/sched/build_policy.o] Error 1
>>> In file included from kernel/sched/build_utility.c:52:
>>> kernel/sched/sched.h:87:11: fatal error: asm/paravirt_api_clock.h: No such file or directory
>>>    87 | # include <asm/paravirt_api_clock.h>
>>>       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>> compilation terminated.
>>> make[3]: *** [scripts/Makefile.build:288: kernel/sched/build_utility.o] Error 1
>>> make[3]: Target '__build' not remade because of errors.
>>> make[2]: *** [scripts/Makefile.build:550: kernel/sched] Error 2
>>>
>>> Randy Dunlap has sent a patch that fixes it, which I just reviewed:
>>>
>>> https://lore.kernel.org/r/20220316204146.14000-1-rdunlap@infradead.org/
>>
>> Applied, thanks Nathan!
>>
>>> It would be nice if this could be taken with the pull (or submitted with
>>> the pull in a v2 as I see Qian's comment) to avoid regressing the build.
>>
>> Will do.
> 
> Thank you a lot for the quick response and fix, I appreciate it!

and my thanks to both of you for taking care of that.

-- 
~Randy