Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d0e2573a-7736-bb3e-9f6a-5fa25e6d31a2@ddn.com>
Date:   Wed, 23 Mar 2022 11:26:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [RFC PATCH] getvalues(2) prototype
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>,
        Miklos Szeredi <mszeredi@redhat.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-api@vger.kernel.org, linux-man@vger.kernel.org,
        linux-security-module@vger.kernel.org, Karel Zak <kzak@redhat.com>,
        Ian Kent <raven@themaw.net>,
        David Howells <dhowells@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <christian@brauner.io>,
        Amir Goldstein <amir73il@gmail.com>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        Dharmendra Singh <dsingh@ddn.com>
References: <20220322192712.709170-1-mszeredi@redhat.com>
 <YjrJWf+XMnWVd6K0@kroah.com>
From:   Bernd Schubert <bschubert@ddn.com>
In-Reply-To: <YjrJWf+XMnWVd6K0@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVFUbm1wOC9PZnorOTM5ellEZlFMZW44enpDbWFSY2c0dGcxU25tQU44eVJM?=
 =?utf-8?B?cWd3Z2tsVUdlOWI5ZUpvQ2N5MFpCby9BdG12anB4SkUrQVJTd1g3OUdGMVZ5?=
 =?utf-8?B?M25TNEZGWml6QVE1L01vcjUwNnhiN01sSmc1YWFBRGtabHZrdk1yQW1hd3pD?=
 =?utf-8?B?UExWaThyanRaU3hFUmZITE9BcDlheHZaRmlxR1lwSVFZUXRwSnRBQTVTeXRZ?=
 =?utf-8?B?dkVjaWZPUWdoSHpmTGptYXp6aDNhL1dBV2dORExJSGltU0tadHpHeXR1WjZi?=
 =?utf-8?B?dEZGenBZN0FXR1VVUEQvUEt4Y0s2MUNVVm9OTis0RWZibWgzOXhoLzNPcWRS?=
 =?utf-8?B?NW5MS2VMRjBZSXM4ajMxZkplN2xCcE83QzFaMjFlUk9Ud1NNdjJ6WFhyS0FI?=
 =?utf-8?B?VkhDTHNnam5xYmlMSHpjZ1FsSENUUXozWXFwVWFvRUxQdG9Ca0JmSU1sNlM3?=
 =?utf-8?B?QVJHWE1ubUtObndSZFRsMmtkMlJXM1NKbzExdUNxdGdUblB5WlhCSXdRaStl?=
 =?utf-8?B?Q1pFT1pPWjVrRjVHckdZcnNYQ0pUQXhJdHVQekJnb3R6QzhvSG9YWExwSEpJ?=
 =?utf-8?B?anRlUTViNDBDOTFzbC9BWlNXWkpPVnlienZjNmJHaFdnRFBQUjE3VUFjU3N6?=
 =?utf-8?B?aEJhaWVTYWp1VXNWRkZYb3VZaWVsZ3F1R05xc0NIU2FTSGE5S0lsZmU4d2Ro?=
 =?utf-8?B?ZDhOakw5NStObWY5ZzBQTXZLUGZSUnVxK0lYeWx6cGNXeU5hbGtnM01qaVkv?=
 =?utf-8?B?T2xtY3lYN1NIR0pxVGo1WHdvUzBDRnI3dDRRMVNMZW9Kd1ZwZCtCeVJPOXA0?=
 =?utf-8?B?bUxYd0hsRk9aM2grem9VcE90WHhVdDNXZU1keHpOaFlaUnJLY0syYmRLcEsx?=
 =?utf-8?B?cGYyVGZsdEN0cHFhL2NwbGMwYzM0M0FlOXhvZFc4Vm5xaXFFSnkxUHl0Umg3?=
 =?utf-8?B?T2NpZk54ZUlvODlJbUFLcjVsTG5HWGRKUFpTQ21GUVpmTkkzZFlHSS9QQXFS?=
 =?utf-8?B?NXoyN296SUIxVkNDVTR0VGNrMnZ0Z2xkMHpxU05GNURaSE5nTVFIVHFXZFVK?=
 =?utf-8?B?bVhrUi94dm4yejJBS29jMjhCNmlkbWNFemMwU1dlc3krME5MaGJjR2xSTThH?=
 =?utf-8?B?RXZiRW9YMGlMbmF1V2R5M0JEcUZtZVFVWUJnQXNENTNBMko2QkZTbE9GSXFU?=
 =?utf-8?B?bHJ5Ym04amt0K3pkaUZnc2NlZEdva0h6U3lia3hJWENDUmQ4WTl0SXJuLzBi?=
 =?utf-8?B?YjZlc3hLaTVXb3dIY0hjOHJTcGM2Mit0VENXUVdrNmdFVGhTR0ZoNlpGMGhH?=
 =?utf-8?B?aVRQb0drekp2NUluYzNtZmVySFFSaUhOZWNySFdpdDNSWEVYbnZtejV4d0pO?=
 =?utf-8?B?MmNHSk9BSndUVGpKSFNGQVNyS1FDbWFSRlJlYlpEZWVIcW9Tc0hNamI0bTBU?=
 =?utf-8?B?T1B0dEc5SkZRdWE3aWRidlk0VXBQK0FZbHE4VG1QUUFteGUrcFdvSHE1bTBu?=
 =?utf-8?B?ZUhFVFk3bUF1MWVrSG5zRnBMWUdHNDBzcUw1RnN6bU9GQ0xldW52M2hmTkJQ?=
 =?utf-8?B?REFpTnEyQTNuckpOeHhCMVo3ckRPMmthUHgxZXFWcXUvaHVCb25JdWR3R0JS?=
 =?utf-8?B?RVhOYjFBNkxEODVGNXI2WEl6L0lSdTloZXN1Vlo1YjduTkErMVluTE9TVW9v?=
 =?utf-8?B?djFTNHloR0R2TnUzd3FyOW9VRitWb2NBUCs2TmZDZldMMm9qSDlMc1UzUU5P?=
 =?utf-8?B?NmZDN3JzV1dENzhLbTJTbDdIbHhERm5yUU5obDl5TjhzNWorQk5tWTk1SmV3?=
 =?utf-8?B?ZE1PdXJtNFJOeC9YZDhCU1BHU3ZrbDNOK1pndDVlamZPN1YxdG0yRlNucHl0?=
 =?utf-8?B?ZmZzQ3BwYm5ZVXFYcXd0K1pUNHdxWHBjb0lnL0FnTGxTd3J2UEIvT2g1Qksz?=
 =?utf-8?B?cjJPLzJXTjN1NXV3OE9YdFhxOGJ2cDhROFBsZHpHZ05UbDdLSjRGNFNUQkQx?=
 =?utf-8?B?eXd6TGw5Y1RUaU5lS2p5ak1nN0E3QXZoQ3V6MnJrQWpJdjVrME1IZ2d5enNP?=
 =?utf-8?Q?pXeK+a?=
X-OriginatorOrg: ddn.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2178d83-9748-41e3-589c-08da0cb7913b
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1901MB2037.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 10:26:18.3355
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 753b6e26-6fd3-43e6-8248-3f1735d59bb4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DI7E6ZETlwtHxPYV9Qj5DTg8CF9uLi/wocBkv2851btLnOdRD/G0EDxqAqchS96F9KEoRfpy0CDP7XY+2FkAHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR19MB4858
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/23/22 08:16, Greg KH wrote:
> On Tue, Mar 22, 2022 at 08:27:12PM +0100, Miklos Szeredi wrote:
>> Add a new userspace API that allows getting multiple short values in a
>> single syscall.
>>
>> This would be useful for the following reasons:
>>
>> - Calling open/read/close for many small files is inefficient.  E.g. on my
>>    desktop invoking lsof(1) results in ~60k open + read + close calls under
>>    /proc and 90% of those are 128 bytes or less.
> 
> As I found out in testing readfile():
> 	https://lore.kernel.org/r/20200704140250.423345-1-gregkh@linuxfoundation.org
> 
> microbenchmarks do show a tiny improvement in doing something like this,
> but that's not a real-world application.
> 
> Do you have anything real that can use this that shows a speedup?

Add in network file systems. Demonstrating that this is useful locally 
and with micro benchmarks - yeah, helps a bit to make it locally faster. 
But the real case is when thousands of clients are handled by a few 
network servers. Even reducing wire latency for a single client would 
make a difference here.

There is a bit of chicken-egg problem - it is a bit of work to add to 
file systems like NFS (or others that are not the kernel), but the work 
won't be made there before there is no syscall for it. To demonstrate it 
on NFS one also needs a an official protocol change first. And then 
applications also need to support that new syscall first.
I had a hard time explaining weather physicist back in 2009 that it is 
not a good idea to have millions of 512B files on  Lustre. With recent 
AI workload this gets even worse.

This is the same issue in fact with the fuse patches we are creating 
(https://lwn.net/Articles/888877/). Miklos asked for benchmark numbers - 
we can only demonstrate slight effects locally, but out goal is in fact 
to reduce network latencies and server load.

- Bernd