Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Huang, Kai" <kai.huang@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "Hansen, Dave" <dave.hansen@intel.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "sathyanarayanan.kuppuswamy@linux.intel.com" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "Luck, Tony" <tony.luck@intel.com>,
        "ak@linux.intel.com" <ak@linux.intel.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "Huang, Kai" <kai.huang@intel.com>
Subject: RE: [PATCH v2 03/21] x86/virt/tdx: Implement the SEAMCALL base
 function
Thread-Topic: [PATCH v2 03/21] x86/virt/tdx: Implement the SEAMCALL base
 function
Thread-Index: AQHYNsg4xFkq5zuN7EW7F8EKAI7kNKzMXTdA
Date:   Wed, 23 Mar 2022 03:35:45 +0000
Message-ID: <BN9PR11MB5276B5986582F9AD11D993618C189@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <cover.1647167475.git.kai.huang@intel.com>
 <269a053607357eedd9a1e8ddf0e7240ae0c3985c.1647167475.git.kai.huang@intel.com>
In-Reply-To: <269a053607357eedd9a1e8ddf0e7240ae0c3985c.1647167475.git.kai.huang@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4QVLJ4SK4HSoGtu6T7Jxbr4NiDFjL7O0KQkvRWW2ApGouPBsV55J7ffbepwU?=
 =?us-ascii?Q?29iS7kn8v6OD5NVUr8bDSqRxke01PN/DbpmEzNLCA6Aa57HEMimiMN+uF4Jd?=
 =?us-ascii?Q?b02chi8RzmwSBuCXGOHTXEOQviGn2Og04MlEDIZKfyYQsRfjErkgz/R7h3Zy?=
 =?us-ascii?Q?8elB9/cI94bS1F9xBuWSQsP2GIXYnot0Gr1QT/kQVWdRiUBOTDe6I+HRa7Wr?=
 =?us-ascii?Q?Osc1ELwWTp4cUSy+sqxOPVoriu9RY7bzT8ygBP2j/nET3zcoHQRV4kFnZeWl?=
 =?us-ascii?Q?ed3OV8qVKyThdXUjbGqtk6HlvojZ/tye2T+u7Lf3rOqdUVg1ZcMyYHCjfaCF?=
 =?us-ascii?Q?zn1N98OvgfyrFvoU7U8hX57DtbadKYgt3oNHzCIy1gRyjpvLG6VYsjI49eVQ?=
 =?us-ascii?Q?pJsgPpqdnjU4mjukiQHj6ZkAOFPBa+LkNIJ3kgIhPLvXiJC4381mmcKDj9Hk?=
 =?us-ascii?Q?x8o6yGO/Nu6LDXTGazPBaTX7N7mqN5PvYaCcXZamwZ+sKfnit41zyGjqRMRu?=
 =?us-ascii?Q?YcJL7+ny4WSO+BkjgJNxzGiRXZ/jEf6Iyc4vDqfW+0E1LaBnc+AR7lFx0h+M?=
 =?us-ascii?Q?YdZHOa00j+whvzi+Q1DxGv+ceQViRWq0GPUoVDQQkofCIbD3yUazNMtQh/qv?=
 =?us-ascii?Q?mtnQxIyoA99gakreCNHW+uKtIhuYPqRlfEtXWyy1N2ME+KRGYxKmlm+ybYQW?=
 =?us-ascii?Q?G7rfjW46iXis931h0agpQxdPCQoyLw2vXmWL4Vywb3YVmiy7LBIojn0oUHOf?=
 =?us-ascii?Q?H11KVzpz1MEuXVcnUuJfIFydzJ8MAWipIMjfNTtHSLwXg7YdNzqshsJiEYh9?=
 =?us-ascii?Q?igvsBd67bW6ftRnZgCrrLxyPWXsXaVa0HZ0wOA6m9g+SrRtMqu4MR8yV2dJM?=
 =?us-ascii?Q?Z1VBlk46Z6a5FJOe4DbpmF888P6cge2AGeB/gNnPQ9MqOAGEZE6293k3f/Bx?=
 =?us-ascii?Q?eSrbjd5nwvJeZUq59S733OYEFkrKPNl4k3+0Gp6vyJOI5U8qNjJGcTHze7DJ?=
 =?us-ascii?Q?CV1VngrwyJwzwkvuc5pmmlNFg4pZ0G/PgLKJuhn+p82qQOmD6aO6jYIjtt+C?=
 =?us-ascii?Q?nFD9lX+vojvTOoYOPTvDHE1CI6IlsM1JhZmXnksSOedOpILyjQn3wMNYxptd?=
 =?us-ascii?Q?+Qdxhc28zK7WwOLoPW67SixQyKuZkfiIPevZI2x2lqfQGs4c4laI75rJkG/j?=
 =?us-ascii?Q?3sPEmWXvFlyno5lpta6N4n4fhrQghXWGN04OvluSYJxsuSkQRdaQO3DcBHpH?=
 =?us-ascii?Q?o0A88T7p19gwGipe8TR9JLkTEmns2zuvM/Td8uhjGXNB/o8/I5pauD6fOpWV?=
 =?us-ascii?Q?LH0xgRWzEyUyrF/GwD04IUEOpJnT+FFAg72PZ5mX6DNDK6w1NlTm2pMYDp4t?=
 =?us-ascii?Q?HAqXHOaXoweL6w4IK4Ggfce7kHfF+C502SwXkadokIM87KV2V1X+kwaujAPS?=
 =?us-ascii?Q?8ll/2NHzqgnqQsznQty0RcDeP1XqMiX6?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17aa54f8-edc6-45ff-27a1-08da0c7e36ef
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2022 03:35:45.1996
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +GXvvjOJAvF8dJ8y9MHmJFfGT1q0gFmJoNjVM/RW1egNvnChYf6c7BAte8P2F2bs5kKfjvVoxfCvJxo94Rc7Sg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4580
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Kai Huang <kai.huang@intel.com>
> Sent: Sunday, March 13, 2022 6:50 PM
>=20
> Secure Arbitration Mode (SEAM) is an extension of VMX architecture.  It
> defines a new VMX root operation (SEAM VMX root) and a new VMX non-
> root
> operation (SEAM VMX non-root) which isolate from legacy VMX root and
> VMX
> non-root mode.

s/isolate/are isolated/

>=20
> A CPU-attested software module (called the 'TDX module') runs in SEAM
> VMX root to manage the crypto protected VMs running in SEAM VMX non-
> root.
> SEAM VMX root is also used to host another CPU-attested software module
> (called the 'P-SEAMLDR') to load and update the TDX module.
>=20
> Host kernel transits to either the P-SEAMLDR or the TDX module via the
> new SEAMCALL instruction.  SEAMCALLs are host-side interface functions
> defined by the P-SEAMLDR and the TDX module around the new SEAMCALL
> instruction.  They are similar to a hypercall, except they are made by

"SEAMCALLs are ... functions ... around the new SEAMCALL instruction"

This is confusing. Probably just:

"SEAMCALL functions are defined and handled by the P-SEAMLDR and
the TDX module"

> host kernel to the SEAM software.
>=20
> SEAMCALLs use an ABI different from the x86-64 system-v ABI.  Instead,
> they share the same ABI with the TDCALL.  %rax is used to carry both the
> SEAMCALL leaf function number (input) and the completion status code
> (output).  Additional GPRs (%rcx, %rdx, %r8->%r11) may be further used
> as both input and output operands in individual leaf SEAMCALLs.
>=20
> Implement a C function __seamcall() to do SEAMCALL using the assembly
> macro used by __tdx_module_call() (the implementation of TDCALL).  The
> only exception not covered here is TDENTER leaf function which takes
> all GPRs and XMM0-XMM15 as both input and output.  The caller of TDENTER
> should implement its own logic to call TDENTER directly instead of using
> this function.
>=20
> SEAMCALL instruction is essentially a VMExit from VMX root to SEAM VMX
> root, and it can fail with VMfailInvalid, for instance, when the SEAM
> software module is not loaded.  The C function __seamcall() returns
> TDX_SEAMCALL_VMFAILINVALID, which doesn't conflict with any actual error
> code of SEAMCALLs, to uniquely represent this case.

SEAMCALL is TDX specific, is it? If yes, there is no need to have both
TDX and SEAMCALL in one macro, i.e. above can be SEAMCALL_VMFAILINVALID.

Thanks
Kevin