Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220323054001.17344-1-diego.viola@gmail.com> <ac99cc8e-11c2-d96b-9ce1-ce5618b7b378@opensource.wdc.com>
 <CA+ToGPH+FQ-6QM6MWt6Zoe_pTyL6LTn9-=-694f7xLkSVCCr1Q@mail.gmail.com>
 <641a417b-acac-6b0f-c330-b94b6ed97b99@opensource.wdc.com> <CA+ToGPEAhWDwFLNHqXvtuumvdLQb=kzme7fdrgBfb4zojVvDNQ@mail.gmail.com>
 <a030b9b2-d94f-ed62-60bf-cc629da3e944@opensource.wdc.com>
In-Reply-To: <a030b9b2-d94f-ed62-60bf-cc629da3e944@opensource.wdc.com>
From:   Diego Viola <diego.viola@gmail.com>
Date:   Wed, 23 Mar 2022 05:44:39 -0300
Message-ID: <CA+ToGPGVdwXgWTZFa24PDMkpXrVrpM48WAxR4U6d4D9t-k=nJQ@mail.gmail.com>
Subject: Re: [PATCH] ata: libata-core: fix "it's" typos
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        corbet@lwn.net
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Mar 23, 2022 at 5:17 AM Damien Le Moal
<damien.lemoal@opensource.wdc.com> wrote:
>
> On 3/23/22 16:24, Diego Viola wrote:
> > On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal
> > <damien.lemoal@opensource.wdc.com> wrote:
> >>
> >> On 3/23/22 14:52, Diego Viola wrote:
> >>> On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal
> >>> <damien.lemoal@opensource.wdc.com> wrote:
> >>>>
> >>>> On 3/23/22 14:40, Diego Viola wrote:
> >>>>> Use the contraction "it's" instead of the possessive form "its".
> >>>>
> >>>> Well, while at it, let's use proper formal written English, so:
> >>>> s/it's/it is
> >>>> s/isn't/is not
> >>>
> >>> Fine with me, do you want me to send you another patch with those changes?
> >>
> >> Yes please.
> >
> > I sent a v2 patch changing those things you pointed out, however, the
> > whole comment[0] looks informal "But wait.. there's more" and I don't
> > think replacing "it's" with "it is" achieves a lot in this case.
>
> :)
>
> Indeed. Do you want it in or can I drop it ?

Given that the language is mostly informal, I'd rather see the first
patch applied (if that is OK with you). However, I agree with you that
it would be nice to see formal language used, I just don't think I'm
the right person to change all the comments in that file. :(

Thanks,
Diego