Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1291939f-5301-1c94-7cd2-20c0b79476b4@nvidia.com>
Date:   Tue, 22 Mar 2022 23:21:30 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [Patch v5 2/4] memory: tegra: Add MC error logging on tegra186
 onward
Content-Language: en-US
To:     Dmitry Osipenko <digetx@gmail.com>,
        krzysztof.kozlowski@canonical.com, robh+dt@kernel.org,
        thierry.reding@gmail.com, jonathanh@nvidia.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org
Cc:     vdumpa@nvidia.com, Snikam@nvidia.com
References: <20220316092525.4554-1-amhetre@nvidia.com>
 <20220316092525.4554-3-amhetre@nvidia.com>
 <fc8f35f8-ccc5-e847-e988-c4b882e53a44@gmail.com>
 <78a48790-f97c-9897-821b-7f9af0b041bd@gmail.com>
From:   Ashish Mhetre <amhetre@nvidia.com>
In-Reply-To: <78a48790-f97c-9897-821b-7f9af0b041bd@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnA2eURiK2NMWEFaaHI0a1krVDgvRjdBL3VyTXVZUS9yZzlBcVRZN213Nk40?=
 =?utf-8?B?RkxZS1FFOGQ4Nm95cTkrVVgzS250TVdYWENIN0hMRXI2eFRSWW83L3lGaHQ4?=
 =?utf-8?B?cmtSY1lnNFJkaCtibDU1eG1QUkdBMmVTVFBDR2FpWXhxVVBqbzdHUEhTOFVC?=
 =?utf-8?B?bW1CQk93Q3NrZCsyR2dBT2tlekI2cDBUUHdmU0IzME1maUZMOW5nMDN4TWlL?=
 =?utf-8?B?MytyeGZGTUpxaktmaEJlSytBZCt1eE93d21lT2hmNGFrUHpLcmgvanRZWEo5?=
 =?utf-8?B?N1lyNFlwWmlFekZGaTl1U3doVEZsa0ZoM0U0TmtwT01hZVVrYnJlZXVZdVpW?=
 =?utf-8?B?Ulh4OC9adEhwTit2ekpydTRFY3B6eWw2bEFZL1orWkI4Rm9WclZJY0cvcXVP?=
 =?utf-8?B?cDNLcGdwWWVXcjF5YlJFQjdnb3VmeTFrN0kzMzNLYjNqY0pLaCtpWnBxYUtM?=
 =?utf-8?B?TllqVWlra1hJc3pUMklTKzdoc1NLSmNUOXoxVlBNdnFTZlovRStCUml2RDRw?=
 =?utf-8?B?S0k1MS9JNWttVXNET0d1aVhQVHU5aERmK2s0czNoRHp1em9XZEFKQU15TGhJ?=
 =?utf-8?B?cXk1cXltclNIeVJ0YzNXS2MrdEE5RVB4eENZTGVIOWcxT2VTU0hoTEpsODNP?=
 =?utf-8?B?THRhbFhnMkRGYkNlOFNRNjliM2pIOE1ZbURtcy9DQTRWSWNsWlIyRFdwQ0Fj?=
 =?utf-8?B?KzYvUGk4WFBOYmM1U2dJbUFJWXBRN2dwaXhwdVY1RzVhZ3BMQ1JaU2locWox?=
 =?utf-8?B?bE9KWU9nNHRJNnY2WXpFK010SmJhcm9VZ0tnK2Ywd2VRNTdxL0RxUy9rSDVC?=
 =?utf-8?B?dW11cFNwcmU2SENtYXlEMjJ6cnZnTGU0YkMvM0NILytCNUpVQkxKMnZGNjJS?=
 =?utf-8?B?akx5aFhXVzJPcklMVkZvdWZHVEQ5NDFRSXdzeWo4ZFA5TDhFU21nVTlNa1k1?=
 =?utf-8?B?bG5RM3B5OHc1NnVQMHRHZWEwNjZ2RmtYcTZjUGRGd3dJWis5RHBqZE1SNlZj?=
 =?utf-8?B?SVlFZFFIaUpmTnpCdTQvbGZheW9ma1kvU0ZkVGlSVXU4cmY0cXdTR0k3MUZu?=
 =?utf-8?B?ckZqUUVMYmFTTk5GbHYzMGl2eTNuczBFU2U4Z2pzN1RnSHJnZlpGQ3pZR3E5?=
 =?utf-8?B?SFIwNEY1SzJyMUs4VTQxVzVUeTRMN2RHeEppV0ZybXNlTG5saWM4ZHVLZm1S?=
 =?utf-8?B?Tk9EaW5SR2hWME90d3BBQnFUVld4cTE4bXZ1RzQwTWthOVQ5WW9NeVphcTJn?=
 =?utf-8?B?cVJ4dG44ekVDcjAxRC9tSmlxYktXazEyaW8wS0xTSUc5UG1pVDEvYTljemZx?=
 =?utf-8?B?TExzR0srNU1pZVlaSDBNN2FUZU9UUWRtUCtrcTdNSmdMWWNTTjhDWEdaRmpO?=
 =?utf-8?B?dmprMmI3S2Vub25yZVZKK1VRUFZqRXZIeUROcHF2ZFhrWEVGM1NWdUNkbkxT?=
 =?utf-8?B?aEZtbnhXTG9JdHdQRHN5NUdSUVFOZnNDMjRMYWdOaHNlcSs2eC9KS1RIY3hB?=
 =?utf-8?B?MEE4MW5vWVJ4M21jNFBYSk04OUM3c0x6UVBpbXlIYWdDMmVVbCticTVRMmFT?=
 =?utf-8?B?eWtDRHhzcStZcU9mUUtKZVRNT3hZTjhFTXBKc3BHc2trQVk5aDVRbU9JS1hk?=
 =?utf-8?B?ZGp6TC80dWtzWTN0RFBJYVlvSGdBTVBLWWRSTHo2R0w4UnRmSVBIZFROQXRV?=
 =?utf-8?B?cnl6QlpVdWY4WTBRcUs0SkJOd1hETmswcGQyb0M4RHk2c2lsOTIzRlhmRHNh?=
 =?utf-8?B?SVBKMkJoVTlITkg4b3l5SldwaUUycTF5QUtScngxVGlmY0hSbTRFS29oSjRh?=
 =?utf-8?B?TmZhbzFhVVVmWTkvV1VhNFFZdUxvUU9JWktEM04vUkNVTCs5NzFPd1lOMFFs?=
 =?utf-8?B?Y1I2b2hZTllRM1BaZ3FJZTR6WE9WMmhYeEdUeUZ1R0lmQ2JzcER5enF2TWwr?=
 =?utf-8?Q?6kb2OzAQS3eUsPsyRT37auul+HvKok50?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f9fabf7-3e4b-41f6-01c5-08da0c2ca0d3
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4349.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 17:51:44.6529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ri8WoWdrawRwo0VyQeT9CYkWnj9Vb5cl0MW+FFSWPGFQdtxPnqNIB+k3M1stJ5gLBPxJC7JwAl1njK9L2Bw+Kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0150
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/19/2022 9:49 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
> 
> 
> 19.03.2022 18:50, Dmitry Osipenko пишет:
>>> +    mc_has_channels = mc->soc->num_channels && mc->soc->get_int_channel;
>>> +    if (mc_has_channels) {
>>> +            int err;
>>> +
>>> +            err = mc->soc->get_int_channel(mc, &channel);
>>> +            if (err < 0)
>>> +                    return IRQ_NONE;
>>> +
>>> +            /* mask all interrupts to avoid flooding */
>>> +            status = mc_ch_readl(mc, channel, MC_INTSTATUS) & mc->soc->intmask;
>>> +    } else {
>>> +            status = mc_readl(mc, MC_INTSTATUS) & mc->soc->intmask;
>>> +    }
>> So if mc_has_channels=false, while it should be true, then you're going
>> to handle interrupt incorrectly?
> 
> I see now that num_channels and get_int_channel are const, so I don't
> see why mc_has_channels variable is needed. Use mc->soc->num_channels.
> 
> if (mc->soc->num_channels) {

Okay, I will remove mc_has_channels and replace it with
mc->soc->num_channels.