Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-4907-g25ce6f34a9-fm-20220311.001-g25ce6f34
Mime-Version: 1.0
Message-Id: <8d474c46-c354-4dec-920d-dbbc67377690@www.fastmail.com>
In-Reply-To: <e0d3648e-3055-9f9b-878d-0fc22a93a806@189.cn>
References: <20220321162916.1116541-1-15330273260@189.cn>
 <20220321162916.1116541-3-15330273260@189.cn>
 <2644866a-8db2-923e-4227-2aa6d8e375fe@flygoat.com>
 <2c671752-6684-f87b-7b2d-90568d36adde@189.cn>
 <005099b5-33ed-4cb7-f8e4-10e1de780311@flygoat.com>
 <abe784ce-eb9e-0143-dbc3-d415bbedbb81@189.cn>
 <87d4f869-2ae8-f8d3-a55f-1a563cb21115@flygoat.com>
 <e0d3648e-3055-9f9b-878d-0fc22a93a806@189.cn>
Date:   Wed, 23 Mar 2022 03:14:23 +0000
From:   "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To:     "Sui Jingfeng" <15330273260@189.cn>,
        "Maxime Ripard" <mripard@kernel.org>,
        "Thomas Zimmermann" <tzimmermann@suse.de>,
        "Roland Scheidegger" <sroland@vmware.com>,
        "Zack Rusin" <zackr@vmware.com>,
        "Christian Gmeiner" <christian.gmeiner@gmail.com>,
        "David Airlie" <airlied@linux.ie>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
        "Dan Carpenter" <dan.carpenter@oracle.com>,
        "Krzysztof Kozlowski" <krzk@kernel.org>,
        "Andrey Zhizhikin" <andrey.zhizhikin@leica-geosystems.com>,
        "Sam Ravnborg" <sam@ravnborg.org>,
        "David S . Miller" <davem@davemloft.net>,
        "Lucas Stach" <l.stach@pengutronix.de>,
        "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
        "Ilia Mirkin" <imirkin@alum.mit.edu>,
        "Qing Zhang" <zhangqing@loongson.cn>,
        suijingfeng <suijingfeng@loongson.cn>
Cc:     "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        "Huacai Chen" <chenhuacai@kernel.org>,
        "Tiezhu Yang" <yangtiezhu@loongson.cn>, liyi@loongson.cn
Subject: Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


=E5=9C=A82022=E5=B9=B43=E6=9C=8823=E6=97=A5=E4=B8=89=E6=9C=88 =E4=B8=8A=E5=
=8D=883:07=EF=BC=8CSui Jingfeng=E5=86=99=E9=81=93=EF=BC=9A
> On 2022/3/23 10:29, Jiaxun Yang wrote:
>>
>>
>> =E5=9C=A8 2022/3/23 1:53, Sui Jingfeng =E5=86=99=E9=81=93:
>>> Hi, Jiaxun
>>>
>>> Build all dts into vmlinuz will make the vmlinuz bigger and bigger.
>>> How does the kernel get the dtb is another big issue, either from=20
>>> built-in
>>> dtb or pass from the firmware(pmon and uefi etc). This should be
>>> solved with another patch carefully. Providing board specific dts
>>> helps to code review, it helps reviewers understand that there are
>>> variant boards and have to be express with different OF graph.
>> Hi,
>>
>> I insist my taste on those code. If the only intention is to demonstr=
ate
>> the usage of the driver then please just leave them in dt document
>> or commit message.
>>
>>>
>>> Now, there are about 6 dts under arch/mips/boot/dts/loongson/,
>>> Suppose loongson have 1000+ different board, do you want built all
>>> of them into vmlinuz?
>> Note that we are supporting all those boards on "platform" bias. Which
>> means if they share similar design then they will use the same DTS.
>> If we have a new design then unfortunately our kernel binary must gro=
w.
>>
>> For those who intended to build a size-optimized kernel they will be
>> able to disable unused DTS in Kconfig.
>>
>> If you want to blame somebody for the problem then please don't
>> blame us. We tried very hard to fit all those stuff into kernel's mod=
el
>> of devices. You should blame those who did the initial design of
>> Loongson's boot interface that failed to introduce a proper way
>> to describe the platform.
>>
>>>
>>> Besides, ls7a1000 and ls2k1000 lack a i2c driver, gpio driver,
>>> pwm driver, clk driver, can you pay more attention to salve those
>>> problems, please ?
>> Are you trying to make a TODO list for your colleague :-)
>>
>> We , community developers, don't owe you anything. So please
>> don't expect anything from us. I lost access to most Loongson
>> devices since I'm currently study abroad, but I'm determined to
>> keep platform code in a good shape. That's my duty as a maintainer.
>>
>> Thanks.
>> - Jiaxun
>
> Providing a few board specific dts doesn't hurt anybody.

There are a lot of things that don't hurt anybody but we shouldn't do.

The standard of reviewing the code is not "doesn't hurt anybody". It's "=
do the right thing".

Please reference:
https://www.kernel.org/doc/html/latest/process/6.Followthrough.html

>
> Can we leave the problem(passing correct dts to the kernel) untouched =
and
>
> solve it in the feature with a another patch, ok?

Then please drop platform DTS part.

I must NAK this part, sorry.

Thanks
--=20
- Jiaxun