Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Khandelwal, Rajat" <rajat.khandelwal@intel.com>
To:     "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>,
        "bleung@google.com" <bleung@google.com>,
        "Malani, Prashant" <pmalani@google.com>
CC:     "jthies@google.com" <jthies@google.com>,
        "Rao, Abhijeet" <abhijeet.rao@intel.com>,
        "Regupathy, Rajaram" <rajaram.regupathy@intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Westerberg, Mika" <mika.westerberg@intel.com>
Subject: RE: [PATCH] USB4/TBT device routers should wake up during S0ix when
 something gets connected/disconnected or a DP monitor gets plugged in
Thread-Topic: [PATCH] USB4/TBT device routers should wake up during S0ix when
 something gets connected/disconnected or a DP monitor gets plugged in
Thread-Index: AQHYPqA9gj/nefPhe0uZrTXrK6euOKzMw0/A
Date:   Wed, 23 Mar 2022 10:26:37 +0000
Message-ID: <CO1PR11MB48357FE72D34818360D2105E96189@CO1PR11MB4835.namprd11.prod.outlook.com>
References: <20220323101818.3503-1-rajat.khandelwal@intel.com>
In-Reply-To: <20220323101818.3503-1-rajat.khandelwal@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.401.20
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K3phGt0nQV8Irqn/81jAvqoRW0iba4uXNCfE6nxdFY3Ga2t/gumA4KIAcxOW?=
 =?us-ascii?Q?cv/HcH1FgUdTSmoSEpo0JjJyWJt79eFgQ7cJTmWPqnqK49UbsvJvFASPQqzl?=
 =?us-ascii?Q?IsoBEGNfZxeVJhhxFd2lwK8GLaMrociDEf41n3+0bnNC644owScln2KgpYYm?=
 =?us-ascii?Q?9EbOTRno9K/pC1LwK6XIzM9OEbgcJUOuKsmHHc4zQu8XFYEA/Ko03kYkMhXl?=
 =?us-ascii?Q?Avo66Ow3YaSZ2j5jiK0PcuSFRxNr5objiHXJxJ3jN4nRPC+6fUw/3iHm2/oE?=
 =?us-ascii?Q?G2P/K6sccLWiaMlmgu1x5h/H0bto01iYZXjhERyNp+b2hPnrifQlCE/e4tjT?=
 =?us-ascii?Q?YNWJwm6LcfsqjmAUZ+JF5/s0gFh/ae5o+8WKUzWeSmQQZRB1fdv440V4qY39?=
 =?us-ascii?Q?Mg+gm9aicW7azJW+EFlKj2HYTGhggPRI0/RsuuSchr2IRXtfwvjcK8yCDiqr?=
 =?us-ascii?Q?fG3XyVN4q3PsQaT+0ws6zSbl4fBNv1ZHU+YfhEas0x+EyNEbCIS+WFIvEiP5?=
 =?us-ascii?Q?5KK6UgzJHpNwh6ADEfx/E2qgAOnL6Bfac69Pk3po/aHt8S4QiQwFNR0ilrMZ?=
 =?us-ascii?Q?8C9IiD0XrczZE8e9qkgipAQojfwmpSRTX1nSF6GwsecdYcIjm89NwJQkEMEZ?=
 =?us-ascii?Q?ngC3OQah+DZEjtIx/+iLw4w+yp9l+wQpyuqJxmfucE1tKZnyjOGpjjQrf0bQ?=
 =?us-ascii?Q?SJtr544sPhpbxQOCriGC2CYnI/q7noMNmp5fiqhsyQh9ZA6ect202OsRSR4/?=
 =?us-ascii?Q?voASgOXaE4esvY7Fsf+ml92AHn9L7pnoRqGI2eql9EUt8mkBehRFJe4kNXHR?=
 =?us-ascii?Q?L65A/G+Rh8Pw8tlF4eyjwWv4koXWbjo/7C2N7dyCtb9PgfGDGgr5XrFkR20Z?=
 =?us-ascii?Q?IKzOdzXo43kDGJeFl9pLl+4pw7r2r9aMHpDX+7zeNuPMK3k0qCn44zZYKBWL?=
 =?us-ascii?Q?YV7Dj8IiCpk6jRpOkeB/o7U06THNPh628Yqb/ZvreWY0mZWz1u0LFq9pgeXk?=
 =?us-ascii?Q?gh3X7Tr2kmtNyo+wy5GKs3MoilTypDjGfpTjqCnxMohsc6RZosBzd95IOKQB?=
 =?us-ascii?Q?6S0tkUm17cOL68BAVccx+9+H4RnNia9mKoWaPAyHK0yqgqLHgNyz2P57bOks?=
 =?us-ascii?Q?P3kIeZPkv2wN61Gf40f4iOf4oLtWIkHBvmXtxs09XvgFm9CUm7Z8LPI5Erkv?=
 =?us-ascii?Q?pbyfO4dmW2bH+zdrOOAged6Iwy3h/+pJngr6vESRlo6zytl0pZJVuNyhUqjB?=
 =?us-ascii?Q?vB8XTA59/WnB8qZz++uwmdnBhysp2UClc0aZpzlCTsl4LvQ7IJFa+84MF6LN?=
 =?us-ascii?Q?Bcilftc1v5giz8SLjKpdSpMMKleak/9d2RSa3eUBHmE8jcppuoXoYTawwSgx?=
 =?us-ascii?Q?RtNJIu9IbFLOItgR11yJyruLKxFHCYcr+7aHMc/0DIuNR3aeKh/SffcTuQAf?=
 =?us-ascii?Q?DXGaKySVhmm/QD4E1lP8YQmhJ0OQD4VuwLgPbLYt6lADQHUWDKC8/g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4835.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e09fdfb-916c-4ade-62ff-08da0cb79cd5
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2022 10:26:37.5031
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JN+UPA25MDL/frGbqusbwoMhegf4/evGPngUO9fxorUAzPvgLvZvXn4gILOqglp4wRnQ8XYKhFQ8dNO+VLyf4KzhFSec95TuJQ9laSjAxys=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2318
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+Mika
@Malani, Prashant @bleung@google.com This is the patch which fixes the part=
ner issue. Kindly escalate your thoughts.=20

Thanks
Rajat

-----Original Message-----
From: Khandelwal, Rajat <rajat.khandelwal@intel.com>=20
Sent: Wednesday, March 23, 2022 3:48 PM
To: mika.westerberg@linux.intel.com
Cc: Khandelwal, Rajat <rajat.khandelwal@intel.com>; bleung@google.com; jthi=
es@google.com; Malani, Prashant <pmalani@google.com>; Rao, Abhijeet <abhije=
et.rao@intel.com>; Regupathy, Rajaram <rajaram.regupathy@intel.com>; linux-=
usb@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] USB4/TBT device routers should wake up during S0ix when so=
mething gets connected/disconnected or a DP monitor gets plugged in

Device routers don't wake up during S0ix when something is plugged in/out o=
r if a DP monitor gets connected. This causes the linux device to not wake =
up during S0ix cycling as the host router didn't wake up because the device=
 router didn't. This patch adds a new functionality to linux.

Signed-off-by: Rajat-Khandelwal <rajat.khandelwal@intel.com>
---
 drivers/thunderbolt/switch.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c in=
dex d026e305fe5d..4f8056724aa4 100644
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -3067,13 +3067,11 @@ void tb_switch_suspend(struct tb_switch *sw, bool r=
untime)
 			tb_switch_suspend(port->remote->sw, runtime);
 	}
=20
-	if (runtime) {
+	if (runtime || device_may_wakeup(&sw->dev)) {
 		/* Trigger wake when something is plugged in/out */
 		flags |=3D TB_WAKE_ON_CONNECT | TB_WAKE_ON_DISCONNECT;
 		flags |=3D TB_WAKE_ON_USB4;
 		flags |=3D TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE | TB_WAKE_ON_DP;
-	} else if (device_may_wakeup(&sw->dev)) {
-		flags |=3D TB_WAKE_ON_USB4 | TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE;
 	}
=20
 	tb_switch_set_wake(sw, flags);
--
2.17.1