Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <3eb95fd0-2046-c000-9c0b-c7c7e05ce04a@163.com>
In-Reply-To: <3eb95fd0-2046-c000-9c0b-c7c7e05ce04a@163.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Wed, 23 Mar 2022 06:40:51 -0700
Message-ID: <CANn89i+v=yOd8=-i9cd=vL9U7Q8W0RRNco6CVFv4+Cx6Dj0z5A@mail.gmail.com>
Subject: Re: [PATCH net-next] tcp: make tcp_rcv_state_process() drop monitor friendly
To:     Jianguo Wu <wujianguo106@163.com>
Cc:     David Ahern <dsahern@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
        Menglong Dong <menglong8.dong@gmail.com>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Mar 23, 2022 at 6:05 AM Jianguo Wu <wujianguo106@163.com> wrote:
>
> From: Jianguo Wu <wujianguo@chinatelecom.cn>
>
> In tcp_rcv_state_process(), should not call tcp_drop() for same case,
> like after process ACK packet in TCP_LAST_ACK state, it should call
> consume_skb() instead of tcp_drop() to be drop monitor friendly,
> otherwise every last ack will be report as dropped packet by drop monitor.
>
> Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
> ---

1) net-next is closed

2) Same remarks as for the other patch.
   You mark the packet as consumed, while maybe we had to throw away
some payload from it ?

You will have to wait for net-next being open,
then send patches with one change at a time, with clear explanations
and possibly packetdrill tests.

I am concerned about all these patches making future backports
difficult because of merge conflicts.