Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7e96b7e9-55d9-0354-80cb-dd1c6fef618b@amd.com>
Date:   Wed, 23 Mar 2022 21:48:25 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH 1/1] x86/amd_nb: unexport amd_cache_northbridges()
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        linux-edac@vger.kernel.org, mingo@redhat.com, mchehab@kernel.org,
        airlied@linux.ie, Muralidhara M K <muralimk@amd.com>
References: <20220228161154.54539-1-nchatrad@amd.com>
 <YjDMvYOh8Vizq4xv@zn.tnic> <31759627-1754-8d5d-6d6a-df3010d3e8e0@amd.com>
 <Yjs9X4O3qwamG6ul@zn.tnic>
From:   "Chatradhi, Naveen Krishna" <nchatrad@amd.com>
In-Reply-To: <Yjs9X4O3qwamG6ul@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVRzTURJTldiZFJDZS9OQ1FrTFBjZ0dsQldXeENjSFlYdEoramhZYTlQdlZR?=
 =?utf-8?B?UTF6MzVRbGZXT0tKNEdvZHZmdkIwRWkwVTdPTjh2ZjdVVzNoRGpQQmhZUXZX?=
 =?utf-8?B?bkRpZEhDTFpTV3prSkhsOHlDQzNJSkg0OWpHeDhDYUFVOEw4L3NncWdnc1Qr?=
 =?utf-8?B?RmpYNjB2V3ZBUE9mNlNRLzJFaFZidzlsNUtvc0lCdS9nZmt1bWVQMHRvMXNn?=
 =?utf-8?B?czlxZmRHSE5WZEc2N1VRRHB6Vk5pYVdXclh6amR3cTNLUXorNnZUZG9YOEZt?=
 =?utf-8?B?b2lweS9DemxuWXNjS28wRFczVG1hYWJzOWVlYmJCcGlpUndkVmJMdnhsZElN?=
 =?utf-8?B?TUJtd3NoVVhDUWc4d2hDV2JTdFJxb0trejNGZEJHeXZuSHhEZVR3SEJ3T0pr?=
 =?utf-8?B?enAzQTVlQWFnM2NZdTVGU3NvT3RDcklMb3plbWpIaGdYdDM3WmhjYVZWUi8v?=
 =?utf-8?B?c1hJSTRRQlg2OXJ2R2RLUjFPa3VFSjk2THBXR0hvU2YyM3JJWm9icjdHTGJX?=
 =?utf-8?B?MGVCZ3ZSL3owbG9IL0tudWMvQmt1SWdSS2pjcGRSZCtEKzExUW9mVE50YVVj?=
 =?utf-8?B?ZkM5aUplbVNDTE82cWtUeWp1NGo3NThhdlQrYWxqbDhXam1nVmtxR2orYmxs?=
 =?utf-8?B?YUN5TDcvMWVhMXVuMzByMXFCbUkwZlk5a2pLK1RPZ2VpeFhXWG53U0VBSTdV?=
 =?utf-8?B?T2lRZnJtbU5BbHFONWFIVXBDTlZudVZkZzVPSTM0M2p6ZUJoVmxpNERaUXNW?=
 =?utf-8?B?dmtVV3NEWWwxZXZqYnFFWldqK3ZTTEM0ZWpwOG1tb2x6MTYrL29kVDJYRWVq?=
 =?utf-8?B?QWRBSmc4L1Yxell4SGlpazMvME5uZGJ2NXU3YWZGWGVvWEZJWVAwcDlhYnJx?=
 =?utf-8?B?eWZmV1RXekFyaXZWcTRQU3Z3dDkyUy94bnEzQVh1T1RLem1qWVV0SDlJNVBE?=
 =?utf-8?B?VFpwOGJzTk02NjFUTHFWbjdGSEtCeC9abUtaQXF5bXNNU3pESEdZbFJ1S0Zu?=
 =?utf-8?B?VDhEQlJHeStRK0ZDUUZOQlUzM05BN1lGWjVCcTk5aHVZMHlIQ1dWUFdXTnJF?=
 =?utf-8?B?N2NmMzZoaHBhRnV3dGtLYUZibHJUVmZHRy95enlpVXlZWE02TDZKeGE3ZGdR?=
 =?utf-8?B?STJpdWYyM28xMTREYThFdnM1a3dWV2VWMVdOM09OL21qNmpydE15SHZGUGxx?=
 =?utf-8?B?bDhac2RYcm1Vb1UrNGlhay9VamQ0OTIzc2k0YVZlLzRtbm1LdlJkRVY5L3ZE?=
 =?utf-8?B?SUhXRFRvUXpHWVZpbGxMNWZBbFQ4d2NxdmpSK0hIQnNvRDdOMVJ4azFVUUpv?=
 =?utf-8?B?TGNjZ1FBNUpOeEswTitLV0tvTmtETUMwREt1NGc4ZEpFL3BkaG5NTURjVHFM?=
 =?utf-8?B?ZWhjVnlHOUFRNTRtenVSd2FLamtGYkdYMkFoWmo0V2J4YXBtZk9HSW9mVXcx?=
 =?utf-8?B?TjRpQWRMMG4rM1JyVmZkR3pRMTY0MTN6TXl4YkNGc2pDdDRrcUFpWUo0cWFK?=
 =?utf-8?B?T0FSSVBrNTNUN0JpTllDL09GOE1kQXp4V0p0bHk5elRWUDdhdHJLREt6S3RY?=
 =?utf-8?B?c09PSFlvWk5uUEpQdmJqWkxENnJDT2ltOTNqVmQwNHl4ZmJNWUNKMTJ0WXNs?=
 =?utf-8?B?WEVLSWVEUllyUFBMTlp5N2hDUTJhYVR1T1R0a2tzZGdlTE40cTlLVjR0Vm80?=
 =?utf-8?B?NFJScHZVdGF5VWF4N0NWNVZnWFR5bGVoazJhK3hGcTBzcDZIa2p0bGJBMmZk?=
 =?utf-8?B?aDhZclMrZE4wNlg4SzFRcnhieXU2NUNGeVJVQmJNamNmMnZYMnJ6R2N0YnB1?=
 =?utf-8?B?ak05dXVrTmhkeFNUWHVaTmo2clZaTkRuWUxWYXZGa3JSUnFMcU5qZmFmYXhU?=
 =?utf-8?B?VDJMYS9Pa3hzQ2JIZ2xITERINnE0Q0pTRDF3eU8vb01naDBFNG1FMnVOaHNa?=
 =?utf-8?Q?tMq3KKLdTlWquwW8EPW1xJDGiPvgxuJw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2db2b6e4-dd2b-49e5-c20b-08da0ce8cb0b
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5286.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 16:18:40.8196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tnKX7UCN7qsqRRYaFAyLSRlej4Dj0EFdhZanI2X9vmJAa2oMChIuOkh+9n7kT2TbwimM0ngLrPMID0RUE02zmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2662
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SCC_BODY_URI_ONLY,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/23/2022 9:01 PM, Borislav Petkov wrote:
> [CAUTION: External Email]
>
> On Wed, Mar 23, 2022 at 08:54:20PM +0530, Chatradhi, Naveen Krishna wrote:
>> Modules that are using this API comes after the fs_initcall() is called.
> I don't need you to explain this to me - I need you to:
>
> "What I am missing in this commit message is why is it ok to do that?"
>
> I.e., pls explain in the commit message exactly why it is ok to do that
> so that people who read it, will know.
Got it, thanks. I will update the commit message.
>
> Thx.
>
> --
> Regards/Gruss,
>      Boris.
>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.kernel.org%2Ftglx%2Fnotes-about-netiquette&amp;data=04%7C01%7CNaveenKrishna.Chatradhi%40amd.com%7Cb0cc43042e1d4b9cdb7208da0ce2419b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637836463172288920%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=v4zF2o2W33F1rCEg6e0ZZRRqpvxM4BwkvtGSgGSY5cU%3D&amp;reserved=0