Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Mar 2022 09:51:11 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Namjae Jeon <linkinjeon@kernel.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steve French <sfrench@samba.org>,
        Hyunchul Lee <hyc.lee@gmail.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-cifs@vger.kernel.org
Subject: Re: [PATCH] ksmbd: Remove a redundant zeroing of memory
Message-ID: <20220323065111.GO3293@kadam>
References: <f8f1f383c4533a91a6025b1db5827ed6aaab002f.1647980983.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f8f1f383c4533a91a6025b1db5827ed6aaab002f.1647980983.git.christophe.jaillet@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TVaWIINFOahwbDxY51O+8KdioNfV/aUXTVuK4YlzCK0/oRwAIFsun1r9AkCM?=
 =?us-ascii?Q?wF6YaiwOV/wVhv+sa5oL7W+GRatg1V5Soeje6CkUeB5TXwasYOmp0q2q53X5?=
 =?us-ascii?Q?HehHbAvxRE29XSwLGu0Fb7yTHGNC5yiRPooJkekFuTqVXFsAaMUTZOdDLFGF?=
 =?us-ascii?Q?F2qil7xSG1uwwEDFmjRaf2HgE8dtItRxocZXWD7MTAsJ5iD7BWzKIWpU7KjQ?=
 =?us-ascii?Q?BrTGUKa5JnQMWQmhCkZgDIvHOlJwU3AYA9e2KRS7X6kDVggfxyRIr/pELRci?=
 =?us-ascii?Q?jCcNaxf4Ey7HfOTxcgL+KSfLFjKWfnZV9qB+cZE28zRoVwsMeQe4HRCs7FXP?=
 =?us-ascii?Q?OVmvC57GFQh6zvD+9WZIY/Iurjy+HV965d78LKd68ufX/s54HhnexH1pW3Se?=
 =?us-ascii?Q?AIj9lKPdpidC6v5fwWO8gzqSiapMlfRPltbIlndzUfyH/mUCbeEnutgIyzYi?=
 =?us-ascii?Q?GgV5CaGeDxTU/oSIbWjJfdyabGmSJwWnm+ffE05VzeB4CHC93J+mw2Yjb3uY?=
 =?us-ascii?Q?kEF/na66JqzWRLLSuNf0ppqrH5SrjEr1neHA92caXFua0PkfcOBbTEPibDK3?=
 =?us-ascii?Q?rZXhNJSYCaf4LFudIMbY0f+V+BcoWcxs8Uo2a/Ay9KiL7iXrs8kBKNKOs+V9?=
 =?us-ascii?Q?9KFIkl8tRswJzsqYe+atmpSmw/77SA/YWAii623/gqldizU+ZYDojqI+I7Rg?=
 =?us-ascii?Q?389+/xnrNjZzMUgM9Zu7HdCHcuPB8I40y8toWJ87W8/cxNGzp8hlnm8XfwII?=
 =?us-ascii?Q?xoMedWzm7mFlt3pjjiCKp9lL4FKlNKhnZFKHK+f1Ct70kg8phyJD+1A4b88w?=
 =?us-ascii?Q?OzT/IGHT9VH1jpj95BLujYlx4ZWSpCvuxXSnSoAJ8UPvBbg7PH58BIsoaemQ?=
 =?us-ascii?Q?oV2p7LHudUvwTZAky/RCVJBikc9yODBOKD5+Chh5GdlRdCn8JzuXDYfypCFR?=
 =?us-ascii?Q?ibsTFI/YzxEqVEYbEZF4cRsxO6cQxcNvzg9J/hSpjS710POUzBwAYIZ4m4L5?=
 =?us-ascii?Q?HRpEQ1+GTyBknsrklOAklZU4FkdHFF3lutlWHK8nlAnCNn62Qt3CwAVEutzm?=
 =?us-ascii?Q?uK3KlIG7tKHsPI3Vl5KLMM4xUfNzWaDecAO0QIShk1mr4gNNVlXHND2UZ73k?=
 =?us-ascii?Q?W5lpaKKzKLBf3l5oescYcWrSFFhR6OLsTqxwGWYHnS9+Hdu3ZXKmUlfzqGLy?=
 =?us-ascii?Q?qtBRcB4gzuiwgeRMsNZ7c0pZ/SDdnVOQF4Iy4h47Xoa/8rlf6ZrhUBVzB83z?=
 =?us-ascii?Q?eZRipX/E/J1E8o6H3Sg/shylRTvaQ/JL6sx0w89yApn0eme43Vn6gd73ADmB?=
 =?us-ascii?Q?yW/Ahe98/NRNw2OFjniVwR1+Y1U6FqG438h7XPPgrLusNC0JzfJi5LIGN4Lk?=
 =?us-ascii?Q?+l6bv0xuVA1SFT2XTvdPAOKvyQ+0EQ60KnIpoXsiIQLTHQ7YjYri6nuPrGXd?=
 =?us-ascii?Q?pN7lsjLUUWdIi+rerS4WwdRnLx+ueBuck3blnaJhlPtcTeRNDDZUmg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50f86ed4-2caa-47cf-85ce-08da0c998ff5
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 06:51:31.5014
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CQWqdDHCSJHZRTqjGkifNaD9BqGiVgk/kVO4348XQz/UUZYigS10FAaahf2FMwFiMmje8AKzXeMnDJZeqTnfZeh8xlzAtVvqIbaRo0VItZ0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2975
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10294 signatures=694350
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 spamscore=0
 mlxlogscore=999 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203230038
X-Proofpoint-GUID: D02bvtlzgTBq0FFQQwDEt1bAZM5VZSwD
X-Proofpoint-ORIG-GUID: D02bvtlzgTBq0FFQQwDEt1bAZM5VZSwD
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 22, 2022 at 09:29:51PM +0100, Christophe JAILLET wrote:
> fill_transform_hdr() already call memset(0) on its 1st argument, so there
> is no need to clear it explicitly before calling this function.
> 
> Use kmalloc() instead of kzalloc() to save a few cycles.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Alternatively, fill_transform_hdr() has only one caller. So its memset()
> could be removed instead and this kzalloc() left as is.
> ---
>  fs/ksmbd/smb2pdu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
> index bcb98109bac9..0e4f819e5859 100644
> --- a/fs/ksmbd/smb2pdu.c
> +++ b/fs/ksmbd/smb2pdu.c
> @@ -8434,7 +8434,7 @@ int smb3_encrypt_resp(struct ksmbd_work *work)
>  	if (ARRAY_SIZE(iov) < rq_nvec)
>  		return -ENOMEM;
>  
> -	work->tr_buf = kzalloc(sizeof(struct smb2_transform_hdr) + 4, GFP_KERNEL);
> +	work->tr_buf = kmalloc(sizeof(struct smb2_transform_hdr) + 4, GFP_KERNEL);
                                                                 ^^^
fill_transform_hdr() does not clear the last 4 bytes.

regards,
dan carpenter