Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp216522pxb; Wed, 23 Mar 2022 16:40:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgU1AyP9HIFutMLIPrfzsyIkNPScOquMN5EAOv70iQkOHTnmyz9evhpkfB2jhyj/cPL8v3 X-Received: by 2002:a63:6c8a:0:b0:37c:62da:a647 with SMTP id h132-20020a636c8a000000b0037c62daa647mr1802260pgc.423.1648078859050; Wed, 23 Mar 2022 16:40:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648078859; cv=none; d=google.com; s=arc-20160816; b=OZ2UeW2wf/MZa7lgqqrcIpDaLC7cfqpKwPk6tS5R358FC99NpztQ3fRDaGMJ7IWsby zD5EN+mh/UzM3IBQpo9yEeXi0tSb0yifbsO84oz4g7ByN18UzGbRn777mTGdBm1l7Zux sHZ3gy36wU1Mr+2P3oVr/YrOGui8OLqQmx59oTS3RaP1Ae8/1kFOXCyT+5M06uHfZKl/ R0NoloyktvpgrlNsp6zQx1jKw7v4YjyqYC1i5X9XOiQmLaZspOlol+RbCPTQkpeUAqOI jkOG3SW2y+yHx+79C68yIzUW8Wf/QVemNRFHbPpm7Y+1crxOzuJn7g9ZIFmH3+B1st63 uzyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=FiqNhl/cI6wxGkLb9mBZPXXy7xwymO3zqp/WgxUHXUI=; b=zTcOosNO8roenT5NuZyayUL9yIJLk0knguBLhFOlOtRMLeg3T47x6iJ818mJ55Lu9M HmTY+aMeaCRJh4ouDbC5wji51FEeo4mZqzgYRC3SXRmwhTAEQ/H+vBiJm7dQ/0xbRGU4 7fM9oGrYWbscX9Zy3RcBhMbXoVd0ttkLd9Pklf5RUaY3kuI3c41O4/v2JTmY8hITvbbf 32sOzBUBq11GEWJNAoIUUpQK8aLgwsEmyX3d+wsAtGJPj8aBl2g1CW5C71bU5rO5foc4 fI9e8cpMBl2JCbzhf9CufdpROUk1eos8DI0S2g911lQWei1n7p1sXsgC6gAkVhBaTrh9 yiiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="a5D/FC4K"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x16-20020a63fe50000000b003863915bbb4si588400pgj.673.2022.03.23.16.40.44; Wed, 23 Mar 2022 16:40:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="a5D/FC4K"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237236AbiCWOcl (ORCPT + 99 others); Wed, 23 Mar 2022 10:32:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234745AbiCWOck (ORCPT ); Wed, 23 Mar 2022 10:32:40 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC19240A0E for ; Wed, 23 Mar 2022 07:31:07 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id r13so3219917ejd.5 for ; Wed, 23 Mar 2022 07:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=FiqNhl/cI6wxGkLb9mBZPXXy7xwymO3zqp/WgxUHXUI=; b=a5D/FC4KmyFXSpkmdd1sTXSjEHekxQNVKadxhzOXj+hHwRSrg2h+vowP4B0S7FumiU uWrWRF7pylwGxodIO85iyi6P+gshxkOlR1qNhxl26IIsvcCYfiO/7YDF48fcaKX6v2ic qcLgfoogdgP78uaC9hTrNsOSPMDW4bL7Us4UyftSoYC1gvkH7xuC7ESaMHWypZrS9wYP nUHfCZb/NSHBbx1UCIzsjITS8UOBXgtYOLsSLWnwpoCz5ICRy8Js6qwwzmcJ9NJjzHIS GzTwJATBfnl2VxKEra7WUB+2TbCAuTFO1zGdJUhkYrtHFfNOIbZVqhYXZ8Z+z5nXliK0 SP2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=FiqNhl/cI6wxGkLb9mBZPXXy7xwymO3zqp/WgxUHXUI=; b=Pn3zRLE6I/tD+Mqxnoc/zfC4M29x/mRENNnSOKrB4lpP7ZUnv41OgDYXjg2fCy1Rr7 9jKU61nvm7+ctWDWfK4krZFc/fCBoZ2oJqljN5HreU0lZglb6HnccV/6IpZZvkBOy4lk n7vphRdXz8BFfF0EwgrgHsae4Y58wCFWCihxkcDIUqFIPf+XJrBnFSTGL3hSwUO95I6H 92daGx4kO5NIt3YDvBM4+XTuMyS1s0It1vikYiu+huflC9b1i/ehQlI01gAjD/aA73CQ oJJPglmMe8o9Enpd8atxjuWmNr8s+fnegmodztZwWgYBIsNDbDkaM7ey0whH9pWT+mD4 zMhQ== X-Gm-Message-State: AOAM532YinjKdt58rcueX4Ucz9qZQP1FUMXc21GzjehLH1mML5ly5E6j ufLkTs4j8WE65WEVQ4NLO5efjTtLjUZlH5lYjrIfxw== X-Received: by 2002:a17:906:3014:b0:6da:f381:4dfe with SMTP id 20-20020a170906301400b006daf3814dfemr230517ejz.670.1648045865895; Wed, 23 Mar 2022 07:31:05 -0700 (PDT) MIME-Version: 1.0 References: <20220323101818.3503-1-rajat.khandelwal@intel.com> In-Reply-To: From: Benson Leung Date: Wed, 23 Mar 2022 07:30:54 -0700 Message-ID: Subject: Re: [PATCH] USB4/TBT device routers should wake up during S0ix when something gets connected/disconnected or a DP monitor gets plugged in To: "Khandelwal, Rajat" Cc: "mika.westerberg@linux.intel.com" , "Malani, Prashant" , "jthies@google.com" , "Rao, Abhijeet" , "Regupathy, Rajaram" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Westerberg, Mika" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rajat, On Wed, Mar 23, 2022 at 3:26 AM Khandelwal, Rajat wrote: > > +Mika > @Malani, Prashant @bleung@google.com This is the patch which fixes the pa= rtner issue. Kindly escalate your thoughts. > > Thanks > Rajat > > -----Original Message----- > From: Khandelwal, Rajat > Sent: Wednesday, March 23, 2022 3:48 PM > To: mika.westerberg@linux.intel.com > Cc: Khandelwal, Rajat ; bleung@google.com; jt= hies@google.com; Malani, Prashant ; Rao, Abhijeet ; Regupathy, Rajaram ; linu= x-usb@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] USB4/TBT device routers should wake up during S0ix when = something gets connected/disconnected or a DP monitor gets plugged in > > Device routers don't wake up during S0ix when something is plugged in/out= or if a DP monitor gets connected. This causes the linux device to not wak= e up during S0ix cycling as the host router didn't wake up because the devi= ce router didn't. This patch adds a new functionality to linux. > > Signed-off-by: Rajat-Khandelwal > --- > drivers/thunderbolt/switch.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c = index d026e305fe5d..4f8056724aa4 100644 > --- a/drivers/thunderbolt/switch.c > +++ b/drivers/thunderbolt/switch.c > @@ -3067,13 +3067,11 @@ void tb_switch_suspend(struct tb_switch *sw, bool= runtime) > tb_switch_suspend(port->remote->sw, runtime); > } > > - if (runtime) { > + if (runtime || device_may_wakeup(&sw->dev)) { > /* Trigger wake when something is plugged in/out */ > flags |=3D TB_WAKE_ON_CONNECT | TB_WAKE_ON_DISCONNECT; > flags |=3D TB_WAKE_ON_USB4; > flags |=3D TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE | TB_WAKE_ON= _DP; > - } else if (device_may_wakeup(&sw->dev)) { > - flags |=3D TB_WAKE_ON_USB4 | TB_WAKE_ON_USB3 | TB_WAKE_ON= _PCIE; > } > > tb_switch_set_wake(sw, flags); > -- > 2.17.1 > Can you please help double check your email configuration for sending patches and responses to the mailing list? I've checked the linux-usb mailing list archives and they don't capture your original patch email or your forward. https://marc.info/?l=3Dlinux-usb&r=3D1&b=3D202203&w=3D2 I did find Mika's response to your forward, though. Let's get this figured out so that folks can have an easier time applying your patches for evaluation with b4 or similar tools. Thanks, Benson --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org