Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef8f8d44-5fc6-5f8e-c33c-c514eb455596@gmail.com>
Date:   Tue, 22 Mar 2022 20:52:32 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] drivers/bus/brcmstb_gisb.c : Remove the
 suppress_bind_attrs attribute of the driver
Content-Language: en-US
To:     lizhe <sensor1010@163.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20220320064529.12827-1-sensor1010@163.com>
 <CAHp75VfkDbO3J=MgTdRF_UyMvZ9XCJEQcEOUEBuyqEwnrNwbsA@mail.gmail.com>
 <CAHp75Vc5FZ-N68vDhyGhCObUdek6JFccotctH-C5KmZ_boL6Wg@mail.gmail.com>
 <531e91bf.3734.17fb4e3150e.Coremail.sensor1010@163.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <531e91bf.3734.17fb4e3150e.Coremail.sensor1010@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 3/22/2022 8:47 PM, lizhe wrote:
> HI Andy Shevchenko
> Even if it is loaded as a module, its execution flow is still executed 
> through do_one_initcall(),
> __platform_driver_probe() still invoked.
>       So, this suppress_bind_attrs = true is redundant
> 
> https://github.com/torvalds/linux/commit/707a4cdf86e5d6a2c4fad51fb98a6ff3425f820e 
> <https://github.com/torvalds/linux/commit/707a4cdf86e5d6a2c4fad51fb98a6ff3425f820e> 
> 
> 
>      The author has simply added some descriptions here. Nothing 
> substantial has changed.

No HTML please, and yes I have seen your patch, and yes I plan on 
applying it. No need to fuss about it however.
-- 
Florian