Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4e07bee8-d3b2-daf4-b107-780e90b5d720@nvidia.com>
Date:   Wed, 23 Mar 2022 14:06:38 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [Patch v5 2/4] memory: tegra: Add MC error logging on tegra186
 onward
Content-Language: en-US
To:     Dmitry Osipenko <digetx@gmail.com>,
        krzysztof.kozlowski@canonical.com, robh+dt@kernel.org,
        thierry.reding@gmail.com, jonathanh@nvidia.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org
Cc:     vdumpa@nvidia.com, Snikam@nvidia.com
References: <20220316092525.4554-1-amhetre@nvidia.com>
 <20220316092525.4554-3-amhetre@nvidia.com>
 <55ae43f0-a22f-b532-2476-c3afa1e2cb73@gmail.com>
From:   Ashish Mhetre <amhetre@nvidia.com>
In-Reply-To: <55ae43f0-a22f-b532-2476-c3afa1e2cb73@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QU9oZXlndWNNdGRGZllZelZLT1B3bkFzV0ZveFMyL2tPdUkyam1jYVV6THBY?=
 =?utf-8?B?Mk1yb3BZTXdRZExOOUdSYjcyV3ZXSDFwUklpUUtPa29CeS9HYzFVN3poTEVQ?=
 =?utf-8?B?QXVCdldhNW9GeDVaU1J1Q2NYcmY1ZlBFVWhiQWZieFhzUkoySUdCSWk5cG82?=
 =?utf-8?B?TnA1cnhPZm8vQ2d3SzdhZE81SGVQS0ZkbWxDZWo2ODZpbWFDNHNnS2JHempH?=
 =?utf-8?B?dkkxM1JkdEpSWS9vMHRvc0xhTVpGMUdGVFhqclovb2EvWWg4cHZ0YW5SV1F1?=
 =?utf-8?B?RmRtdjdsWXZGQVNFNUxIbWYrNXA2akZiM3dOY1FmcklZNTcyc1hybDRDWmo2?=
 =?utf-8?B?c0I5Z3ZHT1IrN2dsdHF4ZDJLelNmQk4xbHpyUmh6MUwzaTlqcCtKaVlmQ1FX?=
 =?utf-8?B?S2NmSW9QRHdoODBsZlVXKzJuUDIwdDFqU0hGOXNTaXgrajNIcEtCMzZlK2Nm?=
 =?utf-8?B?TUxXdVdYWlpWVzI4Z3ZmWW9sN2l0dXF4WGZOdjhOMjlPdHliN2JPeHlkcVZy?=
 =?utf-8?B?a0VmeGxHbFc4VVpzUFlGWTVaSGFmaENUaCt0SGZOdW9hQlo5WFZSSDY2NlQ3?=
 =?utf-8?B?UGUrRWswSW5wOE81Y3paZk9QLzRDR2F5Yk9oZDU1TE5ZUUMyS2c5MUNyUmZR?=
 =?utf-8?B?cGliNmlJZ3JuTTRHcVNJQ1RDSFp5VE1Qa05nODZ4NFc5cDhzV2dUbm12a21T?=
 =?utf-8?B?V05INFdzeUVYWVVEbVVYSDZSa1AvaHU0RTkzdXFRQ2pIY2x6RTRHMXI1TUY1?=
 =?utf-8?B?UHpKVWxnSDE5eUtEVlB2c3FZQjUzRi92WnFYZHFOQlZsR1hZRlRKWjZhUnhw?=
 =?utf-8?B?cjBzaVp6TS9NN1hUK0EyMG1OWS94OWdNYlN4QXVyeVBSQWZiMVBtbE5uNVFr?=
 =?utf-8?B?QTU5bUZsa2RXaWdRYmNLekgzRTVIV0NQS2xWRk0vc2wzZTFpUkN6Wk05ZW14?=
 =?utf-8?B?Y1pNZnhEb2pJdWI1MzRyVGF3ZzRXUUo1TCtyUWhVTkRRT2tEZVQ1WHZ5RGdL?=
 =?utf-8?B?L0lyNmV2WU9TZEhVejgxUSt3Q1cvcEppNFBzUVRjVzk4UVhRcFNzcVExeGV1?=
 =?utf-8?B?eXg5WGkwV29PSlA1T3BzdUt4aTRrMXpTU01wNXBGclMwNlJvbDRZa2FleHJ6?=
 =?utf-8?B?SnVEZVJ6OUlYV3N1dWU5U24yWG8yM24rM2hHNHdUQTVJSVlCd1RKZTFmaWUv?=
 =?utf-8?B?MWkySk5xYmNEaUp4VnpYU2V4d1p5SlRYZ0R4dndhaTVmWkFXK0ZCWldacE9O?=
 =?utf-8?B?WG0rWkt1VzNxbG9WWlYzWDhzbDlXWjczRksrUGNWekU0STdrMUR0UTJBYjBQ?=
 =?utf-8?B?MjRnNWxVbjQ2ZmZOSTY4UVU2QWVNRTNGNVRGRU5DeHNzV1IxSEl5TGVxN1dW?=
 =?utf-8?B?dGV3eGpUL0dFZndCNVdheDJXdmwwaFVRM2lrbXJlRGRFelBDLzFYWFpmSFVm?=
 =?utf-8?B?Tk9GTGx2WGdlMHdnYkVaanBGRmtRd0pCVUdURDc4Mkk3a3hpcjFGY3J2Q2ZQ?=
 =?utf-8?B?Y1BTdElFNzQ3ZWZLMXRtU2N5S0ZMcGF3VVI1eFlFaER2MWcwZ01UaWpTL0xV?=
 =?utf-8?B?QndnaUZNMGFiZExtZUR2RU9Ya2lzYkEybzBWMkVHbFNNbmI4RGxhY1g3L2Zw?=
 =?utf-8?B?RUhDM21LT2VBR3RZTWVXcmdMdFRtS3RBSllsMWl1Z3lqNXdKb3l2VnJROHZF?=
 =?utf-8?B?UTNJcndJQlNQVnlaS1grUGllY1FlaFV3cmtxUUFDRm9hUm12eXJLUTFiR3c2?=
 =?utf-8?B?cWVteUF3cXZUMUp3ak5OQXBQV3F0cWhNejZRLzdYK1UrenYza2RUQkxXbm1Q?=
 =?utf-8?B?ZHJ6Q0x6YlEwYWRWQlBXM21sRVdYdVp2TC94ZVJBM0FwQVYzQU41ZENEdVlW?=
 =?utf-8?B?aDJCRWhBUVRjcUNGb2E0endkVm1QbEtlTW41dG5SYkdlSzNhTXZqKzRwVXFy?=
 =?utf-8?Q?NvnNIJzwQedC5/hHkjuevy+G65QmDMma?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b7c292a-bbbd-48e1-5e9d-08da0ca84762
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4349.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 08:36:51.9889
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SWl9fR7XRjiMEyWe/7OptNyMfxfkBUT3gbIwWBadsN7pFbrGPbQYt07JI3smxS3wyJ46aIuoftvB/4clx6XRoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2917
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/20/2022 6:23 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
> 
> 
> 16.03.2022 12:25, Ashish Mhetre пишет:
>> +static int tegra186_mc_get_channel(const struct tegra_mc *mc, int *mc_channel)
>> +{
>> +     u32 status;
>> +
>> +     status = mc_ch_readl(mc, MC_BROADCAST_CHANNEL, MC_GLOBAL_INTSTATUS);
>> +
>> +     switch (status & mc->soc->int_channel_mask) {
>> +     case BIT(0):
>> +             *mc_channel = 0;
>> +             break;
>> +
>> +     case BIT(1):
>> +             *mc_channel = 1;
>> +             break;
>> +
>> +     case BIT(2):
>> +             *mc_channel = 2;
>> +             break;
>> +
>> +     case BIT(3):
>> +             *mc_channel = 3;
>> +             break;
> 
> This won't work if multiple bits are set at once.

I talked with our HW team and they said that it's technically possible
that interrupts can come at multiple channels at same time. SW can take
care of this by logging interrupts at first channel and then clearing
bit of that. Then take care of interrupts from next channel and so on.
I'll update the patches accordingly in next version.