Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Mar 2022 19:02:47 +0100 (CET)
From:   Miroslav Benes <mbenes@suse.cz>
To:     Sathvika Vasireddy <sv@linux.ibm.com>
cc:     linuxppc-dev@lists.ozlabs.org, jpoimboe@redhat.com,
        peterz@infradead.org, linux-kernel@vger.kernel.org, aik@ozlabs.ru,
        mpe@ellerman.id.au, rostedt@goodmis.org,
        naveen.n.rao@linux.vnet.ibm.com
Subject: Re: [RFC PATCH 1/3] objtool: Move common code to utils.c
In-Reply-To: <20220318105140.43914-2-sv@linux.ibm.com>
Message-ID: <alpine.LSU.2.21.2203231859420.10670@pobox.suse.cz>
References: <20220318105140.43914-1-sv@linux.ibm.com> <20220318105140.43914-2-sv@linux.ibm.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

> +#define sym_for_each_insn(file, sym, insn)                              \
> +	for (insn = find_insn(file, sym->sec, sym->offset);             \
> +	     insn && &insn->list != &file->insn_list &&                 \
> +		insn->sec == sym->sec &&                                \
> +		insn->offset < sym->offset + sym->len;                  \
> +	     insn = list_next_entry(insn, list))
> +
> +#endif /* UTILS_H */

Since you include <objtool/utils.h> in check.c, you can remove the 
definition of sym_for_each_insn() macro from check.c as well.

I wonder if it would make sense to move all these helper functions to 
utils.c and utils.h. Might be connected to what Josh wrote about his work 
on objtool interface.

Regards
Miroslav