Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Mar 2022 21:35:45 +0100
From:   Valentin =?utf-8?B?VmlkacSH?= <vvidic@valentin-vidic.from.hr>
To:     Joseph Qi <jiangqi903@gmail.com>
Cc:     Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
        linux-kernel@vger.kernel.org, Tuo Li <islituo@gmail.com>,
        Dayvison <sathlerds@gmail.com>, ocfs2-devel@oss.oracle.com,
        Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: quota_local: fix mount crash of
 filesystems with quota enabled
Message-ID: <YjozIZ3j8Oczc7W8@valentin-vidic.from.hr>
References: <20220322031215.1449435-1-vvidic@valentin-vidic.from.hr>
 <0bb64f66-6343-72d4-3948-6c6dd49be41a@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0bb64f66-6343-72d4-3948-6c6dd49be41a@gmail.com>
Precedence: bulk

On Tue, Mar 22, 2022 at 03:32:35PM +0800, Joseph Qi wrote:
> Thanks for pointing this out. My fault when reviewing the introduced commit.
> But this change will lead to access uninitialized dqi_gqlock when
> ocfs2_global_read_info() fails.
> How about the following way?

Looks good and works for me :)

Tested-by: Valentin Vidic <vvidic@valentin-vidic.from.hr>

-- 
Valentin