Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-4911-g925b585eab-fm-20220323.003-g925b585e
Mime-Version: 1.0
Message-Id: <38779286-d176-4f2e-8908-d82bf8d60f07@www.fastmail.com>
In-Reply-To: <d6c61a10-e671-3543-5653-ceb3d9ed60cf@roeck-us.net>
References: <20220323115752.360409-1-alistair@alistair23.me>
 <d6c61a10-e671-3543-5653-ceb3d9ed60cf@roeck-us.net>
Date:   Thu, 24 Mar 2022 07:08:53 +1000
From:   Alistair <alistair@alistair23.me>
To:     "Guenter Roeck" <linux@roeck-us.net>, shawnguo@kernel.org,
        linux-watchdog@vger.kernel.org, s.hauer@pengutronix.de,
        wim@linux-watchdog.org,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org
Cc:     devicetree@vger.kernel.org, kernel@pengutronix.de,
        linux-imx@nxp.com, festevam@gmail.com,
        "Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v4] watchdog: imx2_wdg: Allow ping on suspend
Content-Type: text/plain
Precedence: bulk

On Wed, 23 Mar 2022, at 11:07 PM, Guenter Roeck wrote:
> On 3/23/22 04:57, Alistair Francis wrote:
> > The i.MX watchdog cannot be disabled by software once it has been
> > enabled. This means that it can't be stopped before suspend.
> > 
> > For systems that enter low power mode this is fine, as the watchdog will
> > be automatically stopped by hardware in low power mode. Not all i.MX
> > platforms support low power mode in the mainline kernel. For example the
> > i.MX7D does not enter low power mode and so will be rebooted 2 minutes
> > after entering sleep states.
> > 
> > This patch introduces a device tree property "fsl,ping-during-suspend"
> > that can be used to enable ping on suspend support for these systems.
> > 
> > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> What is the difference to earlier versions ?

Sorry, I should have included a changelog.

I just fixed the spelling of alow/allow in the title

Alistair

> 
> Guenter
>