Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: QDlOpQnacpGPu6hM54Z+u+J28Y+VPJzDbcUVnx1i0axDseifclILUh7Pud/qavmkxidnFK+V/W
 1p4wJDZ0NBZZrRYy2abyTd1Ncppfm6Zb4YMzOHBOlLheMgM4d0NJ1tNEH+t6uQ88SOFgkPR8W9
 nkRuj2Z1QwKQSs4nc4k5t6CR0LTATxlzrxIt2xsVsJtIavUBHnY8dq1oB248bh2z+02Atczcvg
 zMuy/+I2CLWAK7z5HSV2N4B2H/uyCpAvUY+YZiP9hsnojOEHEXF5dXfpgGRSSsvz7O5LNMqO82
 ZdpsaQIrn0PcH0aQILqEQI1w
IronPort-SDR: JE/HpoZ7nsDM/JElCW+yU7qpE344jSuzxykXY7BEfJVaWu+gqrukgMTufRHK43Bc/ACi9Js49X
 eajDxoDpUV3ZYCCjxSB4rWvF/TWn+E+btkW+ra1ow1a6b2zuQpRdq14mj9sxM8kP5yZO8DmHb2
 yW/ThlHIYGPAGEj+TS4uONwwyPSd4ceaFd/AtyblQ5bSEpIqQBkhln0kpmynYiWLSP6SPlnLwV
 Y+TMmq1fxWX+8yA2x9QGmm+gEL045ohhLZpqy3nvl5vqfSAovu6mJbYGeRjtY7xPrtUWl1D3K9
 u20=
WDCIronportException: Internal
Message-ID: <a030b9b2-d94f-ed62-60bf-cc629da3e944@opensource.wdc.com>
Date:   Wed, 23 Mar 2022 17:17:23 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH] ata: libata-core: fix "it's" typos
Content-Language: en-US
To:     Diego Viola <diego.viola@gmail.com>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        corbet@lwn.net
References: <20220323054001.17344-1-diego.viola@gmail.com>
 <ac99cc8e-11c2-d96b-9ce1-ce5618b7b378@opensource.wdc.com>
 <CA+ToGPH+FQ-6QM6MWt6Zoe_pTyL6LTn9-=-694f7xLkSVCCr1Q@mail.gmail.com>
 <641a417b-acac-6b0f-c330-b94b6ed97b99@opensource.wdc.com>
 <CA+ToGPEAhWDwFLNHqXvtuumvdLQb=kzme7fdrgBfb4zojVvDNQ@mail.gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <CA+ToGPEAhWDwFLNHqXvtuumvdLQb=kzme7fdrgBfb4zojVvDNQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/23/22 16:24, Diego Viola wrote:
> On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal
> <damien.lemoal@opensource.wdc.com> wrote:
>>
>> On 3/23/22 14:52, Diego Viola wrote:
>>> On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal
>>> <damien.lemoal@opensource.wdc.com> wrote:
>>>>
>>>> On 3/23/22 14:40, Diego Viola wrote:
>>>>> Use the contraction "it's" instead of the possessive form "its".
>>>>
>>>> Well, while at it, let's use proper formal written English, so:
>>>> s/it's/it is
>>>> s/isn't/is not
>>>
>>> Fine with me, do you want me to send you another patch with those changes?
>>
>> Yes please.
> 
> I sent a v2 patch changing those things you pointed out, however, the
> whole comment[0] looks informal "But wait.. there's more" and I don't
> think replacing "it's" with "it is" achieves a lot in this case.

:)

Indeed. Do you want it in or can I drop it ?

> 
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/ata/libata-core.c#n1399
> 
> Diego


-- 
Damien Le Moal
Western Digital Research