Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220323073626.958652-1-ytcoode@gmail.com>
In-Reply-To: <20220323073626.958652-1-ytcoode@gmail.com>
From:   Joanne Koong <joannelkoong@gmail.com>
Date:   Wed, 23 Mar 2022 10:26:15 -0700
Message-ID: <CAJnrk1YF3PiiHFgQu2K4LN2P-Lx4obQOoQohdgXhG4Fg6WogHg@mail.gmail.com>
Subject: Re: [PATCH bpf-next] bpf: Remove redundant assignment to smap->map.value_size
To:     Yuntao Wang <ytcoode@gmail.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, netdev@vger.kernel.org,
        bpf <bpf@vger.kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Mar 23, 2022 at 2:21 AM Yuntao Wang <ytcoode@gmail.com> wrote:
>
> The attr->value_size is already assigned to smap->map.value_size
> in bpf_map_init_from_attr(), there is no need to do it again in
> stack_map_alloc()
>
> Signed-off-by: Yuntao Wang <ytcoode@gmail.com>

LGTM.
Acked-by: Joanne Koong <joannelkoong@gmail.com>

> ---
>  kernel/bpf/stackmap.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c
> index 34725bfa1e97..6131b4a19572 100644
> --- a/kernel/bpf/stackmap.c
> +++ b/kernel/bpf/stackmap.c
> @@ -106,7 +106,6 @@ static struct bpf_map *stack_map_alloc(union bpf_attr *attr)
>                 return ERR_PTR(-ENOMEM);
>
>         bpf_map_init_from_attr(&smap->map, attr);
> -       smap->map.value_size = value_size;
>         smap->n_buckets = n_buckets;
>
>         err = get_callchain_buffers(sysctl_perf_event_max_stack);
> --
> 2.35.0.rc2
>