Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Mar 2022 13:13:36 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Bernd Schubert <bschubert@ddn.com>
Cc:     Miklos Szeredi <mszeredi@redhat.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-api@vger.kernel.org, linux-man@vger.kernel.org,
        linux-security-module@vger.kernel.org, Karel Zak <kzak@redhat.com>,
        Ian Kent <raven@themaw.net>,
        David Howells <dhowells@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <christian@brauner.io>,
        Amir Goldstein <amir73il@gmail.com>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        Dharmendra Singh <dsingh@ddn.com>
Subject: Re: [RFC PATCH] getvalues(2) prototype
Message-ID: <YjsO8FVJN0gq1LRT@kroah.com>
References: <20220322192712.709170-1-mszeredi@redhat.com>
 <YjrJWf+XMnWVd6K0@kroah.com>
 <d0e2573a-7736-bb3e-9f6a-5fa25e6d31a2@ddn.com>
 <YjsHtg7uzRGUlsb3@kroah.com>
 <f90f4e31-edd0-54a7-8b5e-c722930e9c34@ddn.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f90f4e31-edd0-54a7-8b5e-c722930e9c34@ddn.com>
Precedence: bulk

On Wed, Mar 23, 2022 at 01:06:33PM +0100, Bernd Schubert wrote:
> 
> 
> On 3/23/22 12:42, Greg KH wrote:
> > On Wed, Mar 23, 2022 at 11:26:11AM +0100, Bernd Schubert wrote:
> > > On 3/23/22 08:16, Greg KH wrote:
> > > > On Tue, Mar 22, 2022 at 08:27:12PM +0100, Miklos Szeredi wrote:
> > > > > Add a new userspace API that allows getting multiple short values in a
> > > > > single syscall.
> > > > > 
> > > > > This would be useful for the following reasons:
> > > > > 
> > > > > - Calling open/read/close for many small files is inefficient.  E.g. on my
> > > > >     desktop invoking lsof(1) results in ~60k open + read + close calls under
> > > > >     /proc and 90% of those are 128 bytes or less.
> > > > 
> > > > As I found out in testing readfile():
> > > > 	https://lore.kernel.org/r/20200704140250.423345-1-gregkh@linuxfoundation.org
> > > > 
> > > > microbenchmarks do show a tiny improvement in doing something like this,
> > > > but that's not a real-world application.
> > > > 
> > > > Do you have anything real that can use this that shows a speedup?
> > > 
> > > Add in network file systems. Demonstrating that this is useful locally and
> > > with micro benchmarks - yeah, helps a bit to make it locally faster. But the
> > > real case is when thousands of clients are handled by a few network servers.
> > > Even reducing wire latency for a single client would make a difference here.
> > 
> > I think I tried running readfile on NFS.  Didn't see any improvements.
> > But please, try it again.  Also note that this proposal isn't for NFS,
> > or any other "real" filesystem :)
> 
> How did you run it on NFS? To get real benefit you would need to add a
> READ_FILE rpc to the NFS protocol and code? Just having it locally won't
> avoid the expensive wire calls?

I did not touch anything related to NFS code, which is perhaps why I did
not notice any difference :)

thanks,

greg k-h