Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1103372pxb; Thu, 24 Mar 2022 12:47:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypZkkxPpECVUvhAJ1xi+pqQiUpNcMRGPtGEipM+MiDjlm9SIs+DezfvF7ucD9DA5BAS8if X-Received: by 2002:a17:907:9812:b0:6da:aaaf:7713 with SMTP id ji18-20020a170907981200b006daaaaf7713mr7456363ejc.163.1648151260213; Thu, 24 Mar 2022 12:47:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648151260; cv=none; d=google.com; s=arc-20160816; b=GgY2MqYj0DXCEXSU93aX6uP1TQYpVXhrQKVkhTJHG3mYZOerqOcCi4Xi/TilYiUrFw cMgM9TJsc0a5Ewf4C2Tv75ZwzlZhQhWGiJPkygeKnpYv0AU9iv3dgA+7B9q0Nipg3R0I qaijOyPZm4mLgBAb2iIhwSnsk8+CwM3qN4jCSCB1qb9i+R0wd2riezvwoglwnou/bxPc nmhwhARRS6gU0buQ9E11CnisXXMCnSy+AF3DY7tIwFHKTlhcldYYabeunQakqWvgxhq5 H+7GuwT4ThJQMWi1+w8DZ2PZnT7d+Z1YY9rEqZ2MeUjoWaJT5v5hPK7yNkndjaYdQfdI 3MWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Az4s3bgnP2MWmqVLeQ9zbh1ptxR6Ja+G4u6TZKomgpM=; b=OF6xnNQALTAltpqbjNfGyKXxkPjCZ2+mlwb4kL1rrn6JlUuupNJ0xDuRhyyDU+MUXF 1P+CNXPoPziiqB3ASpHzcP2e1G0l3Xk8YxZJJlZsiTuDphPRIZxoUQtTLu7py2sfrjYE KRddHelvZLxuqt0WdU/FVamzQL0UAfvBo7LcSPtx3csIUuEKjCPwrvhwTIVByq/2Sax6 HgKi0m5+Dby7kCmkCJ4DHyG1oG4WeEV5z1c1kY4ysB2zdimlGWrtc2zJT9HdYpyDVQli BzZKguVElukwnxAT7JBzSFhV0xCiGe9Xl8sAXCtOo/0qCJk2/6KM9g6ZZJL44VpM1yYB JTIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=b9oW72pO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ca12-20020a170906a3cc00b006dfc9fd3d29si287105ejb.587.2022.03.24.12.47.14; Thu, 24 Mar 2022 12:47:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=b9oW72pO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347177AbiCXGjb (ORCPT + 99 others); Thu, 24 Mar 2022 02:39:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348257AbiCXGj2 (ORCPT ); Thu, 24 Mar 2022 02:39:28 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A376C97B8B; Wed, 23 Mar 2022 23:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Az4s3bgnP2MWmqVLeQ9zbh1ptxR6Ja+G4u6TZKomgpM=; b=b9oW72pO9kcKe2RPoYFeS5RvI5 v5/A8SCcQHs6Jg3mpv4MUevHfq/A2ays5LMEi/XH6sS6+1klLfjAufAcDkzQHjpQKKVXI2kWoj2lc mjzJpmns+bOtpgCk/CqrN/DjKKIvLPhsOyDv9pTxVP24GO+kyu2b9+Vix2CrKNG9aHjhlEgLBAewa VkFk4hWpVd6mS7Z7POqqk42oWB3QzppS4ZF78V3mUxoLfp8zztpbtGcquBebQjaHY3Ilo41f4tsqn oRnbNQdJV8/KpAYrKyA6F7G59QeYDOyJysI/pG4UP0F1JphgVEJEtdO+p0r/kOLGZm+FXx6+mueiG drV5ia6w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXH6I-00FrP2-JJ; Thu, 24 Mar 2022 06:37:38 +0000 Date: Wed, 23 Mar 2022 23:37:38 -0700 From: Christoph Hellwig To: Jane Chu Cc: Christoph Hellwig , "david@fromorbit.com" , "djwong@kernel.org" , "dan.j.williams@intel.com" , "vishal.l.verma@intel.com" , "dave.jiang@intel.com" , "agk@redhat.com" , "snitzer@redhat.com" , "dm-devel@redhat.com" , "ira.weiny@intel.com" , "willy@infradead.org" , "vgoyal@redhat.com" , "linux-fsdevel@vger.kernel.org" , "nvdimm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-xfs@vger.kernel.org" Subject: Re: [PATCH v6 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops Message-ID: References: <20220319062833.3136528-1-jane.chu@oracle.com> <20220319062833.3136528-5-jane.chu@oracle.com> <3dabd58b-70f2-12af-419f-a7dfc07fbb1c@oracle.com> <2897ca93-690b-72ed-751d-d0b457d3fbec@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2897ca93-690b-72ed-751d-d0b457d3fbec@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 23, 2022 at 06:43:06PM +0000, Jane Chu wrote: > > it onto ->direct_access. But nothing in this series actually checks > > for it as far as I can tell. > > The flag is checked here, again, I'll spell out the flag rather than > using it as a boolean. Yes. The whole point of a flags value is that it is extensible..