Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Mar 2022 14:46:07 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Richard Fitzgerald <rf@opensource.cirrus.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        - <patches@opensource.cirrus.com>,
        =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux-ALSA <alsa-devel@alsa-project.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v3] dt-bindings: mfd: Fix pinctrl node name warnings
Message-ID: <YjsyryNcGm9ku/kF@google.com>
References: <20220303232350.2591143-1-robh@kernel.org>
 <Yjl6fP2Bylv6ud8W@google.com>
 <CAL_Jsq+5GkEaE9sf5HJMaNQLkZUB_q2Qyv2rzADVD7if1MNvqg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAL_Jsq+5GkEaE9sf5HJMaNQLkZUB_q2Qyv2rzADVD7if1MNvqg@mail.gmail.com>
Precedence: bulk

On Wed, 23 Mar 2022, Rob Herring wrote:

> On Tue, Mar 22, 2022 at 2:28 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Thu, 03 Mar 2022, Rob Herring wrote:
> >
> > > The recent addition pinctrl.yaml in commit c09acbc499e8 ("dt-bindings:
> > > pinctrl: use pinctrl.yaml") resulted in some node name warnings:
> > >
> > > Documentation/devicetree/bindings/mfd/cirrus,lochnagar.example.dt.yaml: \
> > >  lochnagar-pinctrl: $nodename:0: 'lochnagar-pinctrl' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> > > Documentation/devicetree/bindings/mfd/cirrus,madera.example.dt.yaml: \
> > >  codec@1a: $nodename:0: 'codec@1a' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> > > Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml: \
> > >  pin-controller@1c0: $nodename:0: 'pin-controller@1c0' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> > >
> > > Fix the node names to the preferred 'pinctrl'. For cirrus,madera,
> > > nothing from pinctrl.yaml schema is used, so just drop the reference.
> > >
> > > Fixes: c09acbc499e8 ("dt-bindings: pinctrl: use pinctrl.yaml")
> > > Cc: Rafał Miłecki <rafal@milecki.pl>
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > > v2:
> > >  - Fix lochnagar-pinctrl nodename in example
> > > v3:
> > >  - And fix lochnagar-pinctrl nodename in 'required'. Sigh...
> > > ---
> > >  Documentation/devicetree/bindings/mfd/brcm,cru.yaml         | 4 ++--
> > >  Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml | 6 +++---
> > >  .../devicetree/bindings/pinctrl/cirrus,madera.yaml          | 3 ---
> > >  3 files changed, 5 insertions(+), 8 deletions(-)
> >
> > Requires rebase.  Doesn't presently apply.
> 
> It's already in 5.17.

Oh, I see what's happened.

I provided my Ack on v2 *after* this was posted.

Makes sense, thanks.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog