Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com;
Envelope-to: tanureal@opensource.cirrus.com,
 linux-arm-kernel@lists.infradead.org,
 linux-i2c@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 patches@opensource.cirrus.com
Message-ID: <33ed666e-79aa-4779-43d6-4f2e82d91744@xilinx.com>
Date:   Wed, 23 Mar 2022 12:02:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] i2c: cadence: Increase timeout per message if necessary
Content-Language: en-US
To:     <tanureal@opensource.cirrus.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <patches@opensource.cirrus.com>
References: <20220309093147.102385-1-tanureal@opensource.cirrus.com>
 <dd26fa4a-870e-d969-04df-1f42487e2b54@xilinx.com>
 <4af9c968-b837-e984-1051-2dcd240f2c08@opensource.cirrus.com>
 <08dc1f90-586a-a47a-7c13-bce0405c13d6@xilinx.com>
 <3657b9ef-2c2e-82b1-1e2c-3d50c64d84b2@opensource.cirrus.com>
From:   Michal Simek <michal.simek@xilinx.com>
In-Reply-To: <3657b9ef-2c2e-82b1-1e2c-3d50c64d84b2@opensource.cirrus.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 11:02:13.5662
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 31e4cf64-afa2-4a23-fc59-08da0cbc9601
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT029.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR02MB8215
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/23/22 11:07, tanureal@opensource.cirrus.com wrote:
> On 3/22/22 5:18 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>>
>>
>> On 3/22/22 16:34, tanureal@opensource.cirrus.com wrote:
>> > On 3/21/22 3:57 PM, Michal Simek <michal.simek@xilinx.com> wrote:
>> >> +Shubhrajyoti
>> >>
>> >> On 3/9/22 10:31, Lucas Tanure wrote:
>> >> > Timeout as 1 second sets a upper limit on the length of
>> >> > the transfer executed, but there is no maximum length of
>> >> > a write or read message set in i2c_adapter_quirks for this
>> >> > controller.
>> >>
>> >> nit: I would expect that you have run any test and you reached an issue.
>> >> Would be good to describe what exactly you have tried on which >> 
>> configuration to make it super clear.
>> >>
>> >> >
>> >> > To remove that limitation calculate the minimal time
>> >> > necessary, plus some wiggle room, for every message
>> >> > and use it instead of the default one second, if
>> >> > more than one second.
>> >> >
>> >> > Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
>> >> > ---
>> >> >   drivers/i2c/busses/i2c-cadence.c | 12 ++++++++++--
>> >> >   1 file changed, 10 insertions(+), 2 deletions(-)
>> >> >
>> >> > diff --git a/drivers/i2c/busses/i2c-cadence.c > >> 
>> b/drivers/i2c/busses/i2c-cadence.c
>> >> > index 805c77143a0f..b4c1ad19cdae 100644
>> >> > --- a/drivers/i2c/busses/i2c-cadence.c
>> >> > +++ b/drivers/i2c/busses/i2c-cadence.c
>> >> > @@ -760,7 +760,7 @@ static void cdns_i2c_master_reset(struct > >> 
>> i2c_adapter *adap)
>> >> >   static int cdns_i2c_process_msg(struct cdns_i2c *id, struct >> i2c_msg 
>> > *msg,
>> >> >           struct i2c_adapter *adap)
>> >> >   {
>> >> > -    unsigned long time_left;
>> >> > +    unsigned long time_left, msg_timeout;
>> >> >       u32 reg;
>> >> >       id->p_msg = msg;
>> >> > @@ -785,8 +785,16 @@ static int cdns_i2c_process_msg(struct >> cdns_i2c > 
>> *id, struct i2c_msg *msg,
>> >> >       else
>> >> >           cdns_i2c_msend(id);
>> >> > +    /* Minimal time to execute this message */
>> >> > +    msg_timeout = msecs_to_jiffies((1000 * msg->len * >> BITS_PER_BYTE) 
>> > / id->i2c_clk);
>> >> > +    /* Plus some wiggle room */
>> >> > +    msg_timeout += msecs_to_jiffies(500);
>> >> > +
>> >> > +    if (msg_timeout < adap->timeout)
>> >> > +        msg_timeout = adap->timeout;
>> >> > +
>> >> >       /* Wait for the signal of completion */
>> >> > -    time_left = wait_for_completion_timeout(&id->xfer_done, > >> 
>> adap->timeout);
>> >> > +    time_left = wait_for_completion_timeout(&id->xfer_done, > >> 
>> msg_timeout);
>> >> >       if (time_left == 0) {
>> >> >           cdns_i2c_master_reset(adap);
>> >> >           dev_err(id->adap.dev.parent,
>> >>
>> >>
>> >> If my assumption is right and there is any actual issue you had >> please 
>> send v2 and feel free to add there my:
>> >> Acked-by: Michal Simek <michal.simek@xilinx.com>
>> >>
>> >> Thanks,
>> >> Michal
>> >>
>> >>
>> >>
>> > The issue happens for I2C devices that have firmware, which will send > a 
>> big I2C message, but the I2C controller will timeout on it.
>> > That happened for CS35L41 DSP firmware tests, so no particular > 
>> configuration, just a driver sending firmware blob over I2C.
>>
>> How big is it?
>>
>> M
>>
> The firmware has 33868 bytes, and it is split in a few writes. The first one to 
> time out has 20240 bytes:
> 
> [   53.398444] cs35l41 0-0040: DSP1: Firmware version: 3
> [   53.403522] cs35l41 0-0040: DSP1: cs35l41-dsp1-spk-prot.wmfw: Fri 04 Feb 2022 
> 12:01:42 W. Europe Standard Time
> [   55.331688] cdns-i2c e0004000.i2c: timeout waiting on completion
> [   55.336721] cs35l41 0-0040: DSP1: cs35l41-dsp1-spk-prot.wmfw.5: Failed to 
> write 20240 bytes at 0 in PM_PACKED: -110
> 
> 20240 bytes at 100k clock should take 1.6192 seconds, which is more than the 
> current timeout of one second.

ok.

thanks,
Michal