Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <d7e3752e-0aad-e247-3708-41f7aba8248c@lwfinger.net>
Date:   Thu, 24 Mar 2022 10:58:22 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH V2] wireless: broadcom: b43legacy: Fix assigning negative
 value to unsigned variable
Content-Language: en-US
To:     Haowen Bai <baihaowen@meizu.com>, kvalo@kernel.org
Cc:     linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <1648109173-28403-1-git-send-email-baihaowen@meizu.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <1648109173-28403-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/24/22 03:06, Haowen Bai wrote:
> fix warning reported by smatch:
> drivers/net/wireless/broadcom/b43legacy/phy.c:1181 b43legacy_phy_lo_b_measure()
> warn: assigning (-772) to unsigned variable 'fval'
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>

This change makes no change to the executable code, but as long as it makes 
smatch happy -

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Larry

> ---
> V1->V2: modify title of this patch
>   drivers/net/wireless/broadcom/b43legacy/phy.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/b43legacy/phy.c b/drivers/net/wireless/broadcom/b43legacy/phy.c
> index 05404fb..c1395e6 100644
> --- a/drivers/net/wireless/broadcom/b43legacy/phy.c
> +++ b/drivers/net/wireless/broadcom/b43legacy/phy.c
> @@ -1123,7 +1123,7 @@ void b43legacy_phy_lo_b_measure(struct b43legacy_wldev *dev)
>   	struct b43legacy_phy *phy = &dev->phy;
>   	u16 regstack[12] = { 0 };
>   	u16 mls;
> -	u16 fval;
> +	s16 fval;
>   	int i;
>   	int j;
>