Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Khandelwal, Rajat" <rajat.khandelwal@intel.com>
To:     "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>,
        "bleung@google.com" <bleung@google.com>
CC:     "Malani, Prashant" <pmalani@google.com>,
        "jthies@google.com" <jthies@google.com>,
        "Rao, Abhijeet" <abhijeet.rao@intel.com>,
        "Regupathy, Rajaram" <rajaram.regupathy@intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] USB4/TBT device routers should wake up during S0ix when
 something gets connected/disconnected or a DP monitor gets plugged in
Thread-Topic: [PATCH] USB4/TBT device routers should wake up during S0ix when
 something gets connected/disconnected or a DP monitor gets plugged in
Thread-Index: AQHYPqA9gj/nefPhe0uZrTXrK6euOKzMw0/AgAABjICAAH6bkA==
Date:   Wed, 23 Mar 2022 18:11:03 +0000
Message-ID: <CO1PR11MB483543E01BD68B353CDD2DAA96189@CO1PR11MB4835.namprd11.prod.outlook.com>
References: <20220323101818.3503-1-rajat.khandelwal@intel.com>
 <CO1PR11MB48357FE72D34818360D2105E96189@CO1PR11MB4835.namprd11.prod.outlook.com>
 <Yjr21UzWmj4NjItA@lahna>
In-Reply-To: <Yjr21UzWmj4NjItA@lahna>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.401.20
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Y457hpKOmsSJGtPO/WszKwluvUsCIw4F5uI+65QphQAGB4g8Dpjxex2xb6xZ?=
 =?us-ascii?Q?TLAWEUAS1vgzL0KvlW8WJNwcPpVSVA6g6cSiPJVQTLDrbmKfgmgjcFbMwtwI?=
 =?us-ascii?Q?UCAuAQir6ZqNuJTD5Cl6hqggwunaC1TeaoeFivHXLoakHpMULH1BZF/4C3gd?=
 =?us-ascii?Q?6f6SohPK8szuESrFX0dS07OUW1TrBV0D2KUuLZukLNRIgVFpd/rgsBj9nAfC?=
 =?us-ascii?Q?GscXmhAE5+hXb5K2hs2GWCP2R0rG5WDr5mki0pe/0RIzs48lD5k1KH7dgF8X?=
 =?us-ascii?Q?9wyF9IbkFiO377DggrV6en3pwVreDzPueEotnGX533EbNE/PspFPTzehA/ws?=
 =?us-ascii?Q?yUeug+n6eFhf5fCiU4B/TU0D1d6JwYJzADI6wmdW4Q4gQBcpdhPO5pvt1T7+?=
 =?us-ascii?Q?VDelvbJSniZSQelNpy9eSPI/sFGhPKKTGEOxLOW9kYLZddFd4Z7sA5y1167V?=
 =?us-ascii?Q?mGPX0gKEaVkdeYfGBs+CQPPCS6clucCqk/NufvlRBa+GUTVaSqkPLxLFx8UZ?=
 =?us-ascii?Q?5Erm5JRzTxkMi5gOoaAw5nsA7Fa5xklb1yU/f+dyiy7qrG3/i1CkcWWLYriO?=
 =?us-ascii?Q?KlXEO10anvda8PFEKDb/RTLlID/Ip12J98CmmrJdRpMKtE2dpcOscOByJHAw?=
 =?us-ascii?Q?fxPJEAsbUbHVtggEFLaKtMfSgz0J+YwhSbEeLC7FQ8+KPy/6m64pJ0XJ5NAy?=
 =?us-ascii?Q?Im7yK6iYBuAFEtkoKGD2oIjTef9glqE+AruTcVryl6C1qwxWngeJRChrpKq7?=
 =?us-ascii?Q?d8bKL6+GEmWtEd46//oyUCKqgYS8U6X86YyVn9xz1bh5btS9Q/kbya0No/4y?=
 =?us-ascii?Q?y3cWBCa8M6G3NBw+vCcz2lOTuBpamNjGlBgFfPS2ycNO9GD88w7Vhms4cHr/?=
 =?us-ascii?Q?mHGCjAvlX41NI8Q63iiuCmWfJ4Y6MvS1bYC+2RGRbqGdep9GuuOZX9tAkGvx?=
 =?us-ascii?Q?nOHkqVzchb9fLzdUUIgZQ7M/yQPfTQQfcvA41fP/UtN/b5CDeZqcJ+5rvy0c?=
 =?us-ascii?Q?GWWGZSa+fpyad5JGrnUAyLzufe7XiuECB7zeyIHD9lW+DivpEcP7qYez75c2?=
 =?us-ascii?Q?qsxlRDHdaUVyw+w/3+dWt78F08va3/dYLAuJ3Luw2o3uIx2O2xeDqPG7ZMjh?=
 =?us-ascii?Q?4xQXn5o4sqmraXIIYWuNQhpIc42Z3LY46ao0vLbk3Esz5z/ngj+jV/lyu2V9?=
 =?us-ascii?Q?uXLaUcWsf5yJ83B1fy/0RVMjme9PeBK/rX/jB5BajvdgR45ZqgERIPI58DPU?=
 =?us-ascii?Q?v1bNngKFduOZWyUpFK2oOObZ43gnw4c9CEOEv8WCtkVWzU66AO+CyYFdAWn2?=
 =?us-ascii?Q?g82ljP6VExRpEFV1CDpgrcjjDHvO8qRdPYb8tVnEsJBYmHDQvxnPXnAfSBkU?=
 =?us-ascii?Q?gvdC2PTIqVU7o5Z1pDabujhKrA0DRWLb76f7BdXwkO7dGA+VR0liMJQaf41n?=
 =?us-ascii?Q?rOoifNKTjGe9kzIWVS3/fL0p/IgkjqoGF058GHMOTVqHpKh0wX3BZA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4835.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b715ae66-99a7-4b4a-dfbc-08da0cf87e4a
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2022 18:11:03.5668
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6bNKoJTeJPe87/IotPL+I1CRa7IMiHoPaVQBmHmHIP3/VxHys706/pKajGRgdyFYGRoyvLF2AYJ9rWJRo8BjkMMH8qHQa4L/RXIhGs2Ztjg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5884
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

@bleung@google.com
The original bug only targets DP plugins. Should we keep connect/disconnect=
 flows also in loop? As Mika once told me, if the lid of the DUT is closed,=
 and the USB4/TBT device is plugged out/in, the DUT shouldn't wake up as it=
 will cause unnecessary consumption of energy.=20
Please confirm if only DP hotplugs in S0ix for waking are required.

Thanks
Rajat

-----Original Message-----
From: mika.westerberg@linux.intel.com <mika.westerberg@linux.intel.com>=20
Sent: Wednesday, March 23, 2022 4:01 PM
To: Khandelwal, Rajat <rajat.khandelwal@intel.com>
Cc: bleung@google.com; Malani, Prashant <pmalani@google.com>; jthies@google=
.com; Rao, Abhijeet <abhijeet.rao@intel.com>; Regupathy, Rajaram <rajaram.r=
egupathy@intel.com>; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.or=
g
Subject: Re: [PATCH] USB4/TBT device routers should wake up during S0ix whe=
n something gets connected/disconnected or a DP monitor gets plugged in

Hi,

If you want it to be woken up when something is plugged to the USB4 port th=
en I suggest to add this to the "wakeup" capability of the usb4_port itself=
 (see drivers/thunderbolt/usb4_port.c). And make it disabled by default too=
.

On Wed, Mar 23, 2022 at 10:26:37AM +0000, Khandelwal, Rajat wrote:
> +Mika
> @Malani, Prashant @bleung@google.com This is the patch which fixes the pa=
rtner issue. Kindly escalate your thoughts.=20
>=20
> Thanks
> Rajat
>=20
> -----Original Message-----
> From: Khandelwal, Rajat <rajat.khandelwal@intel.com>
> Sent: Wednesday, March 23, 2022 3:48 PM
> To: mika.westerberg@linux.intel.com
> Cc: Khandelwal, Rajat <rajat.khandelwal@intel.com>; bleung@google.com;=20
> jthies@google.com; Malani, Prashant <pmalani@google.com>; Rao,=20
> Abhijeet <abhijeet.rao@intel.com>; Regupathy, Rajaram=20
> <rajaram.regupathy@intel.com>; linux-usb@vger.kernel.org;=20
> linux-kernel@vger.kernel.org
> Subject: [PATCH] USB4/TBT device routers should wake up during S0ix=20
> when something gets connected/disconnected or a DP monitor gets=20
> plugged in
>=20
> Device routers don't wake up during S0ix when something is plugged in/out=
 or if a DP monitor gets connected. This causes the linux device to not wak=
e up during S0ix cycling as the host router didn't wake up because the devi=
ce router didn't. This patch adds a new functionality to linux.
>=20
> Signed-off-by: Rajat-Khandelwal <rajat.khandelwal@intel.com>
> ---
>  drivers/thunderbolt/switch.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/thunderbolt/switch.c=20
> b/drivers/thunderbolt/switch.c index d026e305fe5d..4f8056724aa4 100644
> --- a/drivers/thunderbolt/switch.c
> +++ b/drivers/thunderbolt/switch.c
> @@ -3067,13 +3067,11 @@ void tb_switch_suspend(struct tb_switch *sw, bool=
 runtime)
>  			tb_switch_suspend(port->remote->sw, runtime);
>  	}
> =20
> -	if (runtime) {
> +	if (runtime || device_may_wakeup(&sw->dev)) {
>  		/* Trigger wake when something is plugged in/out */
>  		flags |=3D TB_WAKE_ON_CONNECT | TB_WAKE_ON_DISCONNECT;
>  		flags |=3D TB_WAKE_ON_USB4;
>  		flags |=3D TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE | TB_WAKE_ON_DP;
> -	} else if (device_may_wakeup(&sw->dev)) {
> -		flags |=3D TB_WAKE_ON_USB4 | TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE;
>  	}
> =20
>  	tb_switch_set_wake(sw, flags);
> --
> 2.17.1