Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <65609100-3664-11e3-f229-c203e52888f0@kernel.org>
Date:   Wed, 23 Mar 2022 10:21:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
From:   Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: usb: Add documentation for AM62 USB
 Wrapper module
Content-Language: en-US
To:     Aswath Govindraju <a-govindraju@ti.com>
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Roger Quadros <rogerq@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Kishon Vijay Abraham I <kishon@ti.com>
References: <20220323053524.7009-1-a-govindraju@ti.com>
 <20220323053524.7009-2-a-govindraju@ti.com>
 <f17f1f14-d78f-7b54-7fa7-ebf52c6da90a@kernel.org>
 <8b8dcc55-dda8-0715-ccff-22fbe84ff18a@ti.com>
In-Reply-To: <8b8dcc55-dda8-0715-ccff-22fbe84ff18a@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/03/2022 10:17, Aswath Govindraju wrote:
> Hi Krzysztof,

(...)

>>> +
>>> +  ti,syscon-phy-pll-refclk:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
>>> +    items:
>>> +      - items:
>>> +          - description: Phandle to the SYSCON entry
>>> +          - description: USB phy control register offset within SYSCON
>>> +    description: Specifier for configuring frequency of ref clock input.
>>
>> This is a bit strange. The ref clock is the "ref" input clock, right? In
>> such case use clk_set_rate()... Using syscon for managing clocks is not
>> the proper way.
>>
> 
> The syscon property is not being used to set the ref clock frequency but
> is rather being used to indicate the input clock frequency for USB PHY
> operation. I think the description seems be misleading. I will update it
> in the respin, to reflect the above description.

Yes, please, it will help.

> 
>> Plus all the issues pointed out by Roger.
>>
>>> +
>>> +  '#address-cells':
>>> +    const: 2
>>> +
>>> +  '#size-cells':
>>> +    const: 2
>>
>> No children allowed?
>>
>> I understand this is a wrapper, which explains why you do not include
>> usb-hcd.yaml schema. But since it is a wrapper, what is it wrapping?
>>
> 
> Yes, there is a child node, which would be the dwc3-contoller node.
> Would adding the child node too in the example help capture this better?

Yes, please, because then you will also spot errors when running
dt_binding_check.

You need patternProperties for "^usb@[0-9a-f]+$" referencing Synopsys
schema. Something like:
Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml


Best regards,
Krzysztof