Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <981b55a8-b5a6-6353-97f6-f94d287cd583@amd.com>
Date:   Wed, 23 Mar 2022 14:01:11 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v7 10/13] perf tools: fix NULL point in evsel__env()
Content-Language: en-US
To:     Stephane Eranian <eranian@google.com>, linux-kernel@vger.kernel.org
Cc:     peterz@infradead.org, acme@redhat.com, jolsa@redhat.com,
        songliubraving@fb.com, rafael@kernel.org, ravi.bangoria@amd.com,
        sandipan.das@amd.com
References: <20220322221517.2510440-1-eranian@google.com>
 <20220322221517.2510440-11-eranian@google.com>
From:   Kim Phillips <kim.phillips@amd.com>
In-Reply-To: <20220322221517.2510440-11-eranian@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDM4TDZzNFRoVkdkYjlEOVp5SGFWRmdha1ovNDFWcFA1VTVNSHZDTjJOQWdi?=
 =?utf-8?B?TVhoNWpFRVVXdVZib2RVUHcxRjRweEVrb3Y0QWJYdDRpcVJKNFMyd1RoS2U2?=
 =?utf-8?B?Zm5IVEtYanVrd2NQb1FYS0Vndm13ZUZRV25DcmNYYTVTU2NXV3ZHVTIvT0Jn?=
 =?utf-8?B?OEZBaEdPWkQxbWw1TWJBNGxtalA5VmNOZ0k1dUs3UzRid0xyK2hjMEpUUFha?=
 =?utf-8?B?T1NnS1d0dVozbmhUZFIzMXBYMzJNTW9XRHdqUXVJekdsbFJ5L3VOZ0NmVFBw?=
 =?utf-8?B?SWdOWmRjWUFHVk1wZ0M1VGhBaU9ObnRjVURkMS9tK2I1TUZSUnJGendJdWVt?=
 =?utf-8?B?T0hiQnlwc25HZ0QzOEhOcmhGcE1sTmJKbjhjTTBMSnhnU3p1RFAwcUEydFpH?=
 =?utf-8?B?dDd1NGwrZi9acWN2WHJrY25nSHBkNVVGeG92UzFtMGtaV1ZDdGNRS3VicDBV?=
 =?utf-8?B?aGY1OEI5TWtJUnhROWRmS3FRaTBxTVRMQldtQkx4SEdhN0l6bGh4cGlPN284?=
 =?utf-8?B?dWFpc1Q4ODNpeGZBR0F5dGN4aS9GaHNnc216SkxramNQaCswUnNyRnBXaURl?=
 =?utf-8?B?aEFoK240WE5sTjBpdi9ScTRnL1V5V01OTUhibzVhYk81dWtVMmxNODd0d2NO?=
 =?utf-8?B?eWprK0YrZTFQKytlOXRNemRvR0FCRlJST1N3SzFSbXZtdGVVcHJJbzNwQ29r?=
 =?utf-8?B?OENzeEREYUUrME9QK3RxaW43RmJobENOODZ6TmN5NThaTXkzUXQwWXN5UVRP?=
 =?utf-8?B?SFJkQjBodW84RVZZTlNiNHhVWnFxSTAwODBSb2Z5VFpOdk5RT2ZxMm90M1hR?=
 =?utf-8?B?ZHpoOVZ1bUE2WnlkVjA4d3UwY2V3eGNDNUlxZmsrTXhIR2hUTTdlK0Ivc2h2?=
 =?utf-8?B?U1Q2cGdxYjE4M1pRc0lqdUp1eHpWRGxuUTBKQlhIUHZrZHF1ME9nNFlhY0RR?=
 =?utf-8?B?Tm1pTTl5VnRiRmN1MWJxYlpSdXBMbHcvakhlYlNLR0phN3FBSU9FbmpqYVlU?=
 =?utf-8?B?K1hPSW5mMVNrUlRrWElLUjMzUUwrU25EMTU2T1dsTnVSTGlNalFIUGc2TDdv?=
 =?utf-8?B?NUJEdnlTelYxQUF3UlI2SXdoSHB5elMzd0dHQVpxQnR3SG1udit4d0hITXRn?=
 =?utf-8?B?YS9CaHdpY2Vlc25DOGlFL0ttNk5FSTU1b25lWjBDZXJGdG90aWM4RGtIY1hX?=
 =?utf-8?B?MUdZUHB5M0pEciszbnB0eFVyQmdpVVNlMEF6WENCQUhsaHllSXZUbGJFcGpC?=
 =?utf-8?B?ZE8wT052b0hmUHhjamQrRWxJU1h6N0lvUXFuNkZhNGw1NUpHTmxXckJ0V2Rp?=
 =?utf-8?B?M2xOQzlaSi9TaGtHZ3BFVUlOekhWY0NpaHdxSDhIWEZoajd6enB5S0svdEdY?=
 =?utf-8?B?RWVkWDJiaVBvbERHeVV1TUd3MTlRUFBNL2pyV0hENi9vMFJHQzBPUlpsbDdC?=
 =?utf-8?B?Q3NPbDVrUUFQYy9tQ1paOXFoR3kwaEkrOEVCSUI1TGhZa3VMZXJNcERoSUtU?=
 =?utf-8?B?V3JoWlhzN2tZRUtjMFV2cEVNaXdINFVnSkN1YzNZRFpEMllYMGg0R3FVcDd1?=
 =?utf-8?B?MnQ0YmxYVmRxMmF3OG9wOG1oSnF5czdGdDA4MjRsUTI2N3k0ZVRvRTNaQ0Ey?=
 =?utf-8?B?MVBtclJGZVdjSllVNDNUZ2czWmNRbVR4cU4zNVNjV3JmQ1JGRkdaV3lDVjZh?=
 =?utf-8?B?Q3ZpM0xFN1owcmdmT21XZitKaXZmRDI4K3NoQWZEYmoxQm8yNGRiQmM3WDF0?=
 =?utf-8?B?dGFoVnZSd2psMGxBOXQ0NEt6eUtDVjAzN3pRTFpGcm1TOHpEOFhYUlBvSmxn?=
 =?utf-8?B?am5sRDE0Zlk1MVJ5Z2ZqRFJLdTR4K013OG14dWhpOWE0RDE3V0F0Y0UyU3Zy?=
 =?utf-8?B?eVV2VEE1WmlLWkY1dmhpK1pqN0lkbmtuaG00cXBTUm1nZThYNm1IOS9taUZs?=
 =?utf-8?Q?Thi2Rc0nqrkJmzM7dCbEippQBSmlpj+d?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eedda8c6-3853-4749-9e70-08da0cff806f
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3505.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 19:01:14.0932
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A+wYO6CFbzCMqcHOo2OYNyBwCIvToGP/YFGaybbrz7xio/Hgp82esInNwN5U1udhfbutnqCDOrgbbNc0FEShVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3831
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/22/22 5:15 PM, Stephane Eranian wrote:
> evsel_env() cannot return NULL. In case evsel->evlist->env is NULL default
> to perf_env. Fixes crashes in evsel__open_strerror()
> 
> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
> Reviewed-by: Stephane Eranian <eranian@google.com>
> ---

Signed-off-by: Kim Phillips <kim.phillips@amd.com>

FWIW, here's a link to one of the original submissions:

https://lkml.org/lkml/2022/1/26/1220

Thanks,

Kim