Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <527e9d9e-0dac-3a97-da83-068891a41381@quicinc.com>
Date:   Thu, 24 Mar 2022 06:51:09 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v1 2/3] dt-bindings: clock: Add AST2600 video engine reset
 definition
Content-Language: en-US
To:     Howard Chiu <howard_chiu@aspeedtech.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Joel Stanley <joel@jms.id.au>,
        "andrew@aj.id.au" <andrew@aj.id.au>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <SG2PR06MB2315F68B23BB0998B8F7E93EE6199@SG2PR06MB2315.apcprd06.prod.outlook.com>
From:   Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
In-Reply-To: <SG2PR06MB2315F68B23BB0998B8F7E93EE6199@SG2PR06MB2315.apcprd06.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/24/2022 12:27 AM, Howard Chiu wrote:
> Reset bit for VE is 6
> 
> Signed-off-by: Howard Chiu <howard_chiu@aspeedtech.com>
> ---
>   include/dt-bindings/clock/ast2600-clock.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> index 62b9520a00fd..a7d0ad9539eb 100644
> --- a/include/dt-bindings/clock/ast2600-clock.h
> +++ b/include/dt-bindings/clock/ast2600-clock.h
> @@ -110,6 +110,7 @@
>   #define ASPEED_RESET_PCIE_DEV_OEN	20
>   #define ASPEED_RESET_PCIE_RC_O		19
>   #define ASPEED_RESET_PCIE_RC_OEN	18
> +#define ASPEED_RESET_VIDEO		6

You don't need to add 'resets' for video node in DT so it wouldn't be
needed.

-Jae

>   #define ASPEED_RESET_PCI_DP		5
>   #define ASPEED_RESET_AHB		1
>   #define ASPEED_RESET_SDRAM		0