Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Mar 2022 13:45:15 +0000
From:   Stefan Hajnoczi <stefanha@redhat.com>
To:     Stefano Garzarella <sgarzare@redhat.com>
Cc:     netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
        Arseny Krasnov <arseny.krasnov@kaspersky.com>,
        "David S. Miller" <davem@davemloft.net>, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org,
        "Michael S. Tsirkin" <mst@redhat.com>, Asias He <asias@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net v2 2/3] vsock/virtio: initialize vdev->priv before
 using VQs
Message-ID: <Yjska4v9QaRS2pJQ@stefanha-x1.localdomain>
References: <20220323084954.11769-1-sgarzare@redhat.com>
 <20220323084954.11769-3-sgarzare@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="3R3JLtwl44kUF4kA"
Content-Disposition: inline
In-Reply-To: <20220323084954.11769-3-sgarzare@redhat.com>
Precedence: bulk


--3R3JLtwl44kUF4kA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 23, 2022 at 09:49:53AM +0100, Stefano Garzarella wrote:
> When we fill VQs with empty buffers and kick the host, it may send
> an interrupt. `vdev->priv` must be initialized before this since it
> is used in the virtqueue callback.
>=20
> Fixes: 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free on th=
e_virtio_vsock")
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>  net/vmw_vsock/virtio_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_tran=
sport.c
> index b1962f8cd502..fff67ad39087 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
> @@ -622,6 +622,7 @@ static int virtio_vsock_probe(struct virtio_device *v=
dev)
>  	INIT_WORK(&vsock->event_work, virtio_transport_event_work);
>  	INIT_WORK(&vsock->send_pkt_work, virtio_transport_send_pkt_work);
> =20
> +	vdev->priv =3D vsock;
>  	virtio_device_ready(vdev);

Doh, patch order got me. :)

Stefan

--3R3JLtwl44kUF4kA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmI7JGsACgkQnKSrs4Gr
c8jGEgf+NmY84WZKJt4M3ASm6YsR7skYma09Y+u6pulwtzHks6OpAZzjoXQHGIBS
/VimYO8GzZLJQXM7ZawAR82ynLRJR/fD4c574cymhwYyEucPvzhc6bWD/d0Wxlye
CuDUZ5ogWrl03SkA2Z7qE9hlGMxHXG9alh+uU+riRlLxRfWlxl3UQiuRwYxV9sij
v3VpMkTj4qD0IFb+BJUHCeBaTZYIufDqSExT1dAkOtfZxzsVhbK2aT7kVQT8LgoB
yZUPLgDZ83kCAsVqZfWG2Pxfi91XADhSg31ymOPAKx3Fva+7P2eRIKVXy8wT3yDi
V39sZSRcKgm9AJ/09faSF2UCwrfUKw==
=yTw0
-----END PGP SIGNATURE-----

--3R3JLtwl44kUF4kA--