Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Mar 2022 16:15:15 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Yinan Zhang <zhangyinan2019@email.szu.edu.cn>
Cc:     Sean Anderson <seanga2@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/vm/page_owner_sort.c: add switch between culling
 by stacktrace and txt
Message-Id: <20220324161515.19e74f062210861d71ac414b@linux-foundation.org>
In-Reply-To: <623bc151.1c69fb81.12d57.ef3cSMTPIN_ADDED_BROKEN@mx.google.com>
References: <20211129145658.2491-1-zhangyinan2019@email.szu.edu.cn>
        <f0a8099b-3c60-3e34-078a-be3c1280ca61@gmail.com>
        <623a8074.1c69fb81.33a39.0d6cSMTPIN_ADDED_BROKEN@mx.google.com>
        <20220323120805.45fa9e5a0da60b861bf94671@linux-foundation.org>
        <623bc151.1c69fb81.12d57.ef3cSMTPIN_ADDED_BROKEN@mx.google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 24 Mar 2022 08:54:34 +0800 Yinan Zhang <zhangyinan2019@email.szu.ed=
u.cn> wrote:

> on 2022/3/24 3:08, Andrew Morton wrote:
> > On Wed, 23 Mar 2022 10:05:28 +0800 Yinan Zhang<zhangyinan2019@email.szu=
.edu.cn>  wrote:
> >
> >>>> *(&list[i].txt+offset)) !=3D 0) {
> >>>>  =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 list2[count++] =3D list[i];
> >>>>  =A0=A0=A0=A0=A0=A0=A0=A0=A0 } else {
> >>>>  =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 list2[count-1].num +=3D lis=
t[i].num;
> >>>>
> >>>
> >> You are right. Due to timestamp etc, it's almost impossible to
> >>
> >> cull by txt. And I did observe some blocks differ in head and same in
> >>
> >> stack trace on my linux. The examples I mentioned in patch are
> >>
> >> part of them.
> >>
> >>
> >> Besides, --cull has been added in patch:
> >>
> >> tools/vm/page_owner_sort.c: support for user-defined culling rules
> >>
> > So should I drop this patch?
>=20
> you decide.

I'd rather not.

And dropping this patch makes a huge mess of the series.  So I either
ask for the whole series to be redone and we might miss the merge
window or I send it all in as-is.

Sigh.  I'll send it all in as-is.  Please continue to work on this
issue and if we decide to drop the -c option, please send along a patch
to remove it over the next week or two.