Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030244AbXBZNt4 (ORCPT ); Mon, 26 Feb 2007 08:49:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030240AbXBZNt4 (ORCPT ); Mon, 26 Feb 2007 08:49:56 -0500 Received: from mtagate7.uk.ibm.com ([195.212.29.140]:60463 "EHLO mtagate7.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030233AbXBZNtz (ORCPT ); Mon, 26 Feb 2007 08:49:55 -0500 From: Jan-Bernd Themann To: Roland Dreier Subject: Re: [PATCH] ehea: Optional TX/RX path optimized for SMP Date: Mon, 26 Feb 2007 14:43:46 +0100 User-Agent: KMail/1.8.2 Cc: netdev , Christoph Raisch , "Jan-Bernd Themann" , "linux-kernel" , "linux-ppc" , Marcus Eder , Thomas Klein , Stefan Roscher References: <200702231730.58579.ossthema@de.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200702261443.46791.ossthema@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 31 Hi > Also, as far as the approach of using tasklets, I think it would be > better to use the "fake netdev" approach to continue to use NAPI. > Basically you create a pseudo-netdev for each receive queue and have > NAPI handle the polling for you -- you could look for > drivers/net/cxgb3 for an example of this. > Thanks for pointing us to this solution. We are now building a NAPI version that makes use of these pseudo-netdev. The fairness amongst other netdevices should be better this way. > > Why make this a module option that the user has to set? Are there any > circumstances when someone wouldn't want "significant performance > improvements?" If this approach is just better, then it should just > replace the old code. > We'll change the default behaviour to multi queue, but we'd like to keep the option to run in a single queue mode for debug and backward compabilty. Thanks, Jan-Bernd & Christoph R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/