Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1648005138-28311-1-git-send-email-baihaowen@meizu.com>
In-Reply-To: <1648005138-28311-1-git-send-email-baihaowen@meizu.com>
From:   Todd Kjos <tkjos@google.com>
Date:   Wed, 23 Mar 2022 08:21:09 -0700
Message-ID: <CAHRSSEw2+-GpQe5Ufea1U-fQ4YkL1UR_T4Pt5UjWsgRiF+esDA@mail.gmail.com>
Subject: Re: [PATCH V2] android: binder: Fix duplicate included binder_trace.h
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
        maco@android.com, joel@joelfernandes.org, brauner@kernel.org,
        hridya@google.com, surenb@google.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 22, 2022 at 8:12 PM Haowen Bai <baihaowen@meizu.com> wrote:
>
> Clean up the following includecheck warning:
>
> drivers/android/binder.c: binder_trace.h is included more than once.
>
> No functional change.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1 -> V2: modify title asm/pgtable.h -> binder_trace.h
>
>  drivers/android/binder.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 8351c56..a12aa3c 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -72,7 +72,6 @@
>  #include <linux/cacheflush.h>
>
>  #include "binder_internal.h"
> -#include "binder_trace.h"

This breaks the build. Please test your changes before submitting.

>
>  static HLIST_HEAD(binder_deferred_list);
>  static DEFINE_MUTEX(binder_deferred_lock);
> --
> 2.7.4
>