Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <66a8bb8aebf2a6683aca4303f6b6bf598ed7afd0.camel@pengutronix.de>
Subject: Re: [PATCH 2/2] reset: add support for fwnode
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     =?ISO-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Allan Nielsen <allan.nielsen@microchip.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Date:   Thu, 24 Mar 2022 10:44:20 +0100
In-Reply-To: <20220323172121.220a26e9@fixe.home>
References: <20220323095022.453708-1-clement.leger@bootlin.com>
         <20220323095022.453708-3-clement.leger@bootlin.com>
         <ba95a3fec9c726e2cd61665ac5d7f89d16232d60.camel@pengutronix.de>
         <20220323172121.220a26e9@fixe.home>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Precedence: bulk

On Mi, 2022-03-23 at 17:21 +0100, Clément Léger wrote:
> Le Wed, 23 Mar 2022 16:29:41 +0100,
> Philipp Zabel <p.zabel@pengutronix.de> a écrit :
> 
> > On Mi, 2022-03-23 at 10:50 +0100, Clément Léger wrote:
> > [...]
> > > diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> > > index 61e688882643..f014da03b7c1 100644
> > > --- a/drivers/reset/core.c
> > > +++ b/drivers/reset/core.c
> > > @@ -4,6 +4,7 @@
> > >   *
> > >   * Copyright 2013 Philipp Zabel, Pengutronix
> > >   */
> > > +#include <linux/acpi.h>
> > >  #include <linux/atomic.h>
> > >  #include <linux/device.h>
> > >  #include <linux/err.h>
> > > @@ -70,26 +71,49 @@ static const char *rcdev_name(struct
> > > reset_controller_dev *rcdev)
> > >         if (rcdev->of_node)
> > >                 return rcdev->of_node->full_name;  
> > 
> > Could the above be removed, since reset_controller_register() set
> > rcdev->fwnode to of_fwnode_handle(rcdev->of_node) earlier?
> 
> Yes, this should work in all cases, the only difference is that
> fwnode_get_name() returns the basename of the of_node full_name
> field.
> This is potentially a change from what was displayed before. If you are
> ok with that, I'll drop these lines.

Yes, that should be fine. rcdev_name() is currently only used in
warnings that let driver developers know which reset controller they
used incorrectly.

regards
Philipp