Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Mar 2022 12:08:05 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Yinan Zhang <zhangyinan2019@email.szu.edu.cn>
Cc:     Sean Anderson <seanga2@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/vm/page_owner_sort.c: add switch between culling
 by stacktrace and txt
Message-Id: <20220323120805.45fa9e5a0da60b861bf94671@linux-foundation.org>
In-Reply-To: <623a8074.1c69fb81.33a39.0d6cSMTPIN_ADDED_BROKEN@mx.google.com>
References: <20211129145658.2491-1-zhangyinan2019@email.szu.edu.cn>
        <f0a8099b-3c60-3e34-078a-be3c1280ca61@gmail.com>
        <623a8074.1c69fb81.33a39.0d6cSMTPIN_ADDED_BROKEN@mx.google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 23 Mar 2022 10:05:28 +0800 Yinan Zhang <zhangyinan2019@email.szu.ed=
u.cn> wrote:

> >> *(&list[i].txt+offset)) !=3D 0) {
> >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 list2[count++] =3D list[i];
> >> =A0=A0=A0=A0=A0=A0=A0=A0=A0 } else {
> >> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 list2[count-1].num +=3D list[i=
].num;
> >>
> >
> >
> You are right. Due to timestamp etc, it's almost impossible to
>=20
> cull by txt. And I did observe some blocks differ in head and same in
>=20
> stack trace on my linux. The examples I mentioned in patch are
>=20
> part of them.
>=20
>=20
> Besides, --cull has been added in patch:
>=20
> tools/vm/page_owner_sort.c: support for user-defined culling rules
>=20

So should I drop this patch?