Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <354951e0-d2a8-bf4f-e0c5-081e836bb3c3@kernel.org>
Date:   Wed, 23 Mar 2022 15:11:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
From:   Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: mmc: imx-esdhc: Change imx8mn and imx8mp
 compatible fallback
Content-Language: en-US
To:     Adam Ford <aford173@gmail.com>
Cc:     arm-soc <linux-arm-kernel@lists.infradead.org>,
        Adam Ford-BE <aford@beaconembedded.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20220323134019.3796178-1-aford173@gmail.com>
 <35f58894-ed6d-0af0-e483-7a161ad6625a@kernel.org>
 <CAHCN7x+RLAFnES8b3UMoc6n69ZVSFGOmAZyMeeY1g3aoiDNbZg@mail.gmail.com>
In-Reply-To: <CAHCN7x+RLAFnES8b3UMoc6n69ZVSFGOmAZyMeeY1g3aoiDNbZg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/03/2022 15:00, Adam Ford wrote:
> On Wed, Mar 23, 2022 at 8:56 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 23/03/2022 14:40, Adam Ford wrote:
>>> The SDHC controller in the imx8mn and imx8mp have the same controller
>>> as the imx8mm which is slightly different than that of the imx7d.
>>> Using the fallback of the imx8mm enables the controllers to support
>>> HS400-ES which is not available on the imx7d.
>>>
>>> Signed-off-by: Adam Ford <aford173@gmail.com>
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
>>> index 7dbbcae9485c..d6ea73d76bdd 100644
>>> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
>>> @@ -39,14 +39,14 @@ properties:
>>>        - items:
>>>            - enum:
>>>                - fsl,imx8mm-usdhc
>>
>> Your change looks reasonable, but why imx8mm is compatible with imx7d?
> 
> I saw that, and I wasn't sure the best way to go about  fixing it.  If
> I move the 8mm out of the imx7d category, do I need to add it to the
> enum list associated with the imx8mm, or can I just delete it from the
> enum leaving the const for imx8mm good enough?
> 

The DTS is using:
  compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc"
which looks incorrect, based on what you wrote in commit description.
Since fsl,imx8mm-usdhc has its own compatibility-group and defines the
properties for entire family (imx8mm + imx8mn + imx8mp), then I would
assume that either fsl,imx8mm-usdhc is not be compatible with imx7d or
everything is compatible with imx7d. IOW, DTS and bindings should be
changed to one of following:
1. Everything compatible with imx7d:
  compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
  compatible = "fsl,imx8mq-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";

2. A new group:
  compatible = "fsl,imx8mm-usdhc";
  compatible = "fsl,imx8mq-usdhc", "fsl,imx8mm-usdhc";

Which one, I am not sure. My commit 80fd350b95 organized it in (1)
approach, because also that time there was no new group for 8mm (added
in commit 431fae8). I assume NXP engineer knows better, so the better
solution would be (2). In such case, imx8mm has to be moved to the first
enum and all DTS have to be adjusted.


Best regards,
Krzysztof