Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1786001pxb; Fri, 25 Mar 2022 05:44:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz65oXDouwJPOr81NEBFphhnKOzDFkLFua8VpxjbjOeBWFZbY2eKiYLlzoWAG8PhJXtkEe5 X-Received: by 2002:a63:f4e:0:b0:382:1e31:79e8 with SMTP id 14-20020a630f4e000000b003821e3179e8mr8000354pgp.167.1648212248649; Fri, 25 Mar 2022 05:44:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648212248; cv=none; d=google.com; s=arc-20160816; b=P4Fs3bHJSjy4NyIWUdHN7J7LAFnI8fq0nG9fKuR2+0hnucoW5x1bhxHz3HwxdOOZbv ZJNRjO+NMyTa9aYTVsBd5c94zVJH9JIUE9goVD8NQqaMHsfeHuzKbW3T6NNi3bbIyq43 jjQmJgOObFSnMBQ4kWz7s0WhQ6x36mm9HEyUlh9fh+clJy8t1oqNr1qbvSfviVGl6qan 3rZ8b5a5A+DCMTfM7FVGPEByj5Opp2mF9XONRKwpy3AZVwjgNgRHSmlN1j4vo6cr8mar 15/Pxv4T5cPh4O3ZXnUqtUtW/cqjcIC0XuFh904+H65JpCjmU89lXNMHLEqhUOGHuaw4 Y8NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=XYYstwn1s64pcwK5LvShx5Ry1kTzUTbuHMZkOFyWOz8=; b=uakdszNwpaFxTzzrjUcW96Qpd0JOa1k6b5ozxbNERwtHm2WQEZLcXBshkQYi6wWtyc O3onMhiR8eV34KVdAmgNf/WRqEM9eAlpeHlTPG4FV947E/2uX03N2P5Q+ic1srUP2znn mG2jgUbPKpa8be4yiLBE00NjYzF6pZTQ8bqSBZm/ZmS6em1hD/fdeYrGMna//IZVQgyB 3i/exUiIDSjmRZj5CWqiALEq331jiWkYIX+DlP103DoYqukUUCGsNQwLw4NpAqaFf1PN ftznj5HkbKucuETyMNqtL8W/C4YlpdBsLf8L3tTDR+Vq2I608XSxvorCikIrR+QuJP62 TkAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mdaverde-com.20210112.gappssmtp.com header.s=20210112 header.b=ZjsT4c7x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a13-20020a1709027d8d00b00153b2d1640fsi2362245plm.23.2022.03.25.05.43.55; Fri, 25 Mar 2022 05:44:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mdaverde-com.20210112.gappssmtp.com header.s=20210112 header.b=ZjsT4c7x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234540AbiCVOwS (ORCPT + 99 others); Tue, 22 Mar 2022 10:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235251AbiCVOwP (ORCPT ); Tue, 22 Mar 2022 10:52:15 -0400 Received: from mail-oa1-x43.google.com (mail-oa1-x43.google.com [IPv6:2001:4860:4864:20::43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 906098594C for ; Tue, 22 Mar 2022 07:50:47 -0700 (PDT) Received: by mail-oa1-x43.google.com with SMTP id 586e51a60fabf-ddfa38f1c1so1918553fac.11 for ; Tue, 22 Mar 2022 07:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mdaverde-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XYYstwn1s64pcwK5LvShx5Ry1kTzUTbuHMZkOFyWOz8=; b=ZjsT4c7xexfSKGND54aezvA9skGMTBZlXA87WTG7NJQRdzZluD+OHzmiuaoXloyRtp hLl9YFuYKFrp64iAHtzj6qtVcUyqAzCWzhCYS0RNjor9O+5RhIX1Ls4m2z9lcMwQXg6t PqzmhwSWnUKXponrH2tpBf+unNy16PA2JZD/8h6MjI3mnQEd68uqXqCv3LFMmIyTpw7c 09ROx7ObSUyR5UgEnUDu42GN3RGjLuAmlW9xyGx9hyv3vAPNW+Tdv1rwaZKhveF89WCC +SXHw1DJUvAE12r7QEo/tQwnqS0Adq2yK6AKnB/oC5R0HGIE6FTq6uNZL5cAZFnAtTBp 8hEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XYYstwn1s64pcwK5LvShx5Ry1kTzUTbuHMZkOFyWOz8=; b=0WAZ5CFvPPX3dwFw/RBxh6fcYyhB3gRVpFcOB2pBibAkML5ilpssHvgLglpAnq9eBh d8ZEJCUsryG8uXqc1SASrnNjMC3KUP4Wo+Yy5nLYFnBd/i6JfJXF7pTMymhAW3JZT/hi 3BETRvXD0+YQzbKO/KhES6deB9ovEIplnfqLdDryWlTE4PaG2BLz23XbdkiKpoSUoEx8 ZKw3KfU6L49+tYwEG5IrBo9t7QJDjYG3q/f8xBKIpaMFNDRf+60abzvsmcefvfAaSHpU KuvOyvkBFNX0G8CZSbckhTYfYkun84kF27fFYp9qUFq9NqdBxj+bQuBWUcP000Wi8gSp GnMg== X-Gm-Message-State: AOAM531/7Xh+roJL1TGd4XFbUlsaYWoGGe/i9G43io2fHw0Jpl5uD/hu 3gY7orhiGvBJXdz5WkbyzRvqww== X-Received: by 2002:a05:6870:b303:b0:d6:f4d1:990d with SMTP id a3-20020a056870b30300b000d6f4d1990dmr1770423oao.53.1647960646595; Tue, 22 Mar 2022 07:50:46 -0700 (PDT) Received: from pop-os.attlocal.net ([2600:1700:1d10:5830:90b:eeed:e704:d511]) by smtp.gmail.com with ESMTPSA id a15-20020a056870000f00b000de1ab6364dsm2223135oaa.49.2022.03.22.07.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 07:50:46 -0700 (PDT) From: Milan Landaverde Cc: milan@mdaverde.com, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Quentin Monnet , Paul Chaignon , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next] bpf/bpftool: add unprivileged_bpf_disabled check against value of 2 Date: Tue, 22 Mar 2022 10:49:45 -0400 Message-Id: <20220322145012.1315376-1-milan@mdaverde.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In [1], we added a kconfig knob that can set /proc/sys/kernel/unprivileged_bpf_disabled to 2 We now check against this value in bpftool feature probe [1] https://lore.kernel.org/bpf/74ec548079189e4e4dffaeb42b8987bb3c852eee.1620765074.git.daniel@iogearbox.net Signed-off-by: Milan Landaverde --- tools/bpf/bpftool/feature.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c index c2f43a5d38e0..290998c82de1 100644 --- a/tools/bpf/bpftool/feature.c +++ b/tools/bpf/bpftool/feature.c @@ -207,7 +207,10 @@ static void probe_unprivileged_disabled(void) printf("bpf() syscall for unprivileged users is enabled\n"); break; case 1: - printf("bpf() syscall restricted to privileged users\n"); + printf("bpf() syscall restricted to privileged users (without recovery)\n"); + break; + case 2: + printf("bpf() syscall restricted to privileged users (admin can change)\n"); break; case -1: printf("Unable to retrieve required privileges for bpf() syscall\n"); -- 2.32.0