Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Mar 2022 11:16:31 +0100
From:   =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>
To:     Philipp Zabel <p.zabel@pengutronix.de>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Allan Nielsen <allan.nielsen@microchip.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 0/2] add fwnode support to reset subsystem
Message-ID: <20220324111631.64208e6a@fixe.home>
In-Reply-To: <6e04fbc91a924201aac672165a938bf76cf873f1.camel@pengutronix.de>
References: <20220323095022.453708-1-clement.leger@bootlin.com>
        <d2d119b07cb51878904574ff14c8e4dd92c28907.camel@pengutronix.de>
        <20220323170545.79810f56@fixe.home>
        <6e04fbc91a924201aac672165a938bf76cf873f1.camel@pengutronix.de>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Le Thu, 24 Mar 2022 11:08:15 +0100,
Philipp Zabel <p.zabel@pengutronix.de> a =C3=A9crit :

> > =C2=A0- It can be used as a PCIe endpoint, connected to a separate plat=
form
> > =C2=A0=C2=A0 that acts as the PCIe root complex. In this case, all the =
devices
> > =C2=A0=C2=A0 that are embedded on this SoC are exposed through PCIe BAR=
s and the
> > =C2=A0=C2=A0 ARM64 cores of the SoC are not used. Since this is a PCIe =
card, it
> > =C2=A0=C2=A0 can be plugged on any platform, of any architecture suppor=
ting PCIe.
> >=20
> > Appart from adding software node support, the fwnode API would also
> > allow to add ACPI support more easily later. =20
>=20
> Thank you for the explanation. So this would be used by the sparx5
> switch reset driver to provide the microchip,lan966x-switch-reset
> controller via software node?

Exactly.

>=20
> If that needs to be converted to fwnode anyway, it would be nice to
> include the conversion in this series as an example.

Yes indeed, the sparx5 driver was modified in my private tree. I will
change it to use fwnode.

>=20
> [...]
> > On that side, I must say I'm not really competent regarding ACPI
> > which I do not know enough to answer you on that point.
> >=20
> > The discussions we had with Mark Brown regarding fwnode ACPI support
> > pointed out the fact that we should not create unwanted ACPI support
> > by using the same descriptions/specifications that exists for the
> > device-tree. In order to avoid that, we suggested to explicitely left
> > out ACPI with this fwnode support. This will allow to specify that
> > support later and integrate it in the subsystem that have been
> > converted to fwnode. =20
>=20
> Ok.
>=20
> > >=20
> > > On the other hand, I think it would be good to avoid the direct of_no=
de
> > > assignment, possibly by letting devm_reset_controller_register()
> > > initialize of_node or fwnode from the device for most cases, and by
> > > adding of_reset_controller_register() and
> > > fwnode_reset_controller_register() variants that take the node as an
> > > argument for the rest.
> > > That could allow to eventually get rid of the of_node pointer. =20
> >=20
> > Ok, I see that. Do you want this to be done in this series ? =20
>=20
> Just thinking out loudly, before starting to drop the
> rcdev->of_node assigment from drivers en masse, I'd like to use the
> opportunity and turn reset_controller_register() and friends into
> macros that provide the module owner as a parameter, so the explicit
> rcdev->owner =3D THIS_MODULE assignment can be removed from the drivers
> as well.

Indeed, that seems like a good thing to do, direct assignments are often
a pain to change all other the place. BTW, once drivers are converted
to avoid direct assignment of the of_node field, it will be removable,
the fwnode field will be sufficient for all operations.

Thanks,

Cl=C3=A9ment

--=20
Cl=C3=A9ment L=C3=A9ger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com