Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1875913pxb; Fri, 25 Mar 2022 07:12:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwM0H79e65dIYZVtx+Uol2I72mcVFb4MD+PQ5Lhukk4pxZrbuupBXONoCXSRuP/rDYzLE0g X-Received: by 2002:a17:90b:1c83:b0:1b9:caa:8230 with SMTP id oo3-20020a17090b1c8300b001b90caa8230mr25139452pjb.26.1648217566140; Fri, 25 Mar 2022 07:12:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648217566; cv=none; d=google.com; s=arc-20160816; b=wi8V0XwpgHcDDc7KZJr3tLKZkZfrUXYS/Ahn0iDo+jLLHmgY+PazqRbWuJrByKvfWs RtSeFbtTPrcTohGJQs8vzXFR2o4ZMQg8iJh85xChTbdqi92T7BnHLKODU5UUj2JSketp Op6S7FfK3GxqF7Tsjd4I3CVWLZpYv3lN0RswiZSce4SjLMF4+8Z4xIHbMxjT9iH8Uco/ 7DdbtzKVNjY6hHb0eqm1Gl0bpvvAzPSVr3I/wOBqbGeyM55uO0qBNqE0ugk2zjctEozr CLd8/tjsapI0k0upf+ehLLIglFBcwyTA1bUML0NKt0Afc+YQRuIODaBrgtYa1cWmIgG1 yqlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=58oFgw+aSJKbmcVcBo8WJoE16fYK1EVOuFObJ6dRxLE=; b=tmYD+dzSc/BwxAxvaM71pqspnQjnY0YuafVykuTR8iHZ90RAVt9+TT5RxLAoFW7j5W 9Rrx5NhaJxhU1gCHoAPH4F+2+a7TTnZpWROsbmYaJHt9BqTSmWrQA7wzq+VLQVzBMU8V BE3TVsSADa7csIa1cvDeZrSSkPxVVPv5ekNf744YXemmdbZTaxqjkIU7AnWHvmkZvMlY q4diG73yrdE7kYtSheLSdEoH2E7bECQiLUQMkSnXOk+4R3gI9gst+aU1Hq0haYxkCE5w OG4I/iZgY6nbnPMi0VHTey44lTHXMQh+CGSM9pEa/EsNWROi5jgj/Gq2bfbE/11ZDMQD Th4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="E/euJg1O"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a655606000000b00393c60e611esi2410776pgs.861.2022.03.25.07.12.19; Fri, 25 Mar 2022 07:12:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="E/euJg1O"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344869AbiCWVWb (ORCPT + 99 others); Wed, 23 Mar 2022 17:22:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241081AbiCWVWa (ORCPT ); Wed, 23 Mar 2022 17:22:30 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFF335FDD for ; Wed, 23 Mar 2022 14:20:59 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id bg10so5432642ejb.4 for ; Wed, 23 Mar 2022 14:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=58oFgw+aSJKbmcVcBo8WJoE16fYK1EVOuFObJ6dRxLE=; b=E/euJg1O6WdvDAGao/Ysl1hYIzJqoY1BQobkcH3juoZC8UfixEm9MeHVqh3TPwhQE7 AuwgdU7hITXRZX63oGEzlU8bvgd6wr2tnGaVSGCU9mpHf+iogW5jbqRftYiVetOjyZrN lusdVvRAMlH08NouLi3fBd6vcsV1MwFE0O62eN/OgfnWonVpvCnfcJzpwMFlHfW1Jzjz SyPPmxVFTep5V0qKFyrQ0wRdGAbCx/11vZ3IwlVIYa/csynGUgK1vPxZ+kIAM+WATT5s kN7oH2Ke3aRG3l6Wu8EvrMnI3fjPiHuOakjtuexVDonrVEYx23irntaDnEEZN+eg/5I8 SIBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=58oFgw+aSJKbmcVcBo8WJoE16fYK1EVOuFObJ6dRxLE=; b=syEkaB/drg7jq0B9nb6Zj4uQ0uCxO4+kmIrawJLHlfU+xRclet66EhDT5sNi5c8T9N fmk0hfDu3briPfbf4NosMEIKiR+vY1IAYJf68D2F5IxOrBcqbgUjI7cnI2tMXqsrphfD M/NJaqlZOTueew7fMA3Kfn4h8YjSsb0pdIl+Mm/BLR20B8qD0no+vyhXpwbiWmLlF1BO kKawiwn6cGP5BsKvQ/ujWj61+nzCmfUSsmsJ8O6yeKiD2bmude2dRXrEhjCgDaF6yPvT /ZPhT03SBYxATP5oK643viQtq27Rpz/7TkDrQ8XvBs9gB6OZrVn7fc3XfDf3GBDQ9zeM 1Adg== X-Gm-Message-State: AOAM532UJelKemiw9l+a/1+xFAjGNLoqmDozQpJK1gXeMjdT2P+N4o4v MnDo+jaelI+jUV+3VX9HOkePyPq5hpaV5E2vhfOAqg== X-Received: by 2002:a17:907:c018:b0:6df:e31b:d912 with SMTP id ss24-20020a170907c01800b006dfe31bd912mr2271911ejc.196.1648070458265; Wed, 23 Mar 2022 14:20:58 -0700 (PDT) MIME-Version: 1.0 References: <20220224192036.2388302-1-dlatypov@google.com> In-Reply-To: <20220224192036.2388302-1-dlatypov@google.com> From: Brendan Higgins Date: Wed, 23 Mar 2022 17:20:46 -0400 Message-ID: Subject: Re: [PATCH v2 1/3] kunit: tool: readability tweaks in KernelCI json generation logic To: Daniel Latypov Cc: davidgow@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 24, 2022 at 2:20 PM Daniel Latypov wrote: > > Use a more idiomatic check that a list is non-empty (`if mylist:`) and > simplify the function body by dedenting and using a dict to map between > the kunit TestStatus enum => KernelCI json status string. > > The dict hopefully makes it less likely to have bugs like commit > 9a6bb30a8830 ("kunit: tool: fix --json output for skipped tests"). > > Signed-off-by: Daniel Latypov > Reviewed-by: David Gow Reviewed-by: Brendan Higgins