Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220321231548.14276-7-ansuelsmth@gmail.com>
References: <20220321231548.14276-1-ansuelsmth@gmail.com> <20220321231548.14276-7-ansuelsmth@gmail.com>
Subject: Re: [PATCH v6 06/18] clk: qcom: clk-krait: unlock spin after mux completion
From:   Stephen Boyd <sboyd@kernel.org>
To:     Andy Gross <agross@kernel.org>,
        Ansuel Smith <ansuelsmth@gmail.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 24 Mar 2022 18:04:41 -0700
User-Agent: alot/0.10
Message-Id: <20220325010443.6AE19C340ED@smtp.kernel.org>
Precedence: bulk

Quoting Ansuel Smith (2022-03-21 16:15:36)
> Unlock spinlock after the mux switch is completed to prevent any corner
> case of mux request while the switch still needs to be done.
>=20
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---

Please add a Fixes tag.

>  drivers/clk/qcom/clk-krait.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/clk/qcom/clk-krait.c b/drivers/clk/qcom/clk-krait.c
> index 59f1af415b58..e447fcc3806d 100644
> --- a/drivers/clk/qcom/clk-krait.c
> +++ b/drivers/clk/qcom/clk-krait.c
> @@ -32,11 +32,12 @@ static void __krait_mux_set_sel(struct krait_mux_clk =
*mux, int sel)
>                 regval |=3D (sel & mux->mask) << (mux->shift + LPL_SHIFT);
>         }
>         krait_set_l2_indirect_reg(mux->offset, regval);
> -       spin_unlock_irqrestore(&krait_clock_reg_lock, flags);
> =20
>         /* Wait for switch to complete. */
>         mb();
>         udelay(1);
> +

Please add a comment here indicating we want to make sure the mux
register isn't modified while switching to the new parent.

> +       spin_unlock_irqrestore(&krait_clock_reg_lock, flags);
>  }
>