Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1928594pxb; Fri, 25 Mar 2022 08:07:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNnCrt8vOHu2EZTBx85MWe6oLYSomFwFuwXVGxyYnyc5H2oGjVImzU8cWw+7WTQvRIg6/7 X-Received: by 2002:a05:6638:258f:b0:31a:1c77:f6ef with SMTP id s15-20020a056638258f00b0031a1c77f6efmr5560798jat.25.1648220831965; Fri, 25 Mar 2022 08:07:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648220831; cv=none; d=google.com; s=arc-20160816; b=LXohoeV6C3sxP4rvLB20SNYuKEPaBwHK8HeqWIc/qz4xGTYFjEOSLkoM7DoQSVTRaI 6v9d5hZ73Yx9ZHm9TcCj6jIa11iReMmTy623XTPd+Fa9FuFvd1jbWB3jtZ40EARMQEcd l84nwH1btPUlnlveu0Q4hDYHVc+ZRVe96c2sdxqK7TY1GP/pIRfPSpBrHN/pY1vVOdPE NvVt+3P5h7fAY+VTY0opy+ZCL3OvzzR3xBeInNmyF3i4D3SY5QsH7IEvDcqJnzbgkaoT RdStue6Qe0d4+/Znix43fEaZIg2oACVPiInhsjweeWHTkP/AuEaSMoeztgyPJ1BNFY69 h0EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=5zjowvYEPhFgarxioyhWvgvFMs3P/EONC4TJ8fEToi8=; b=1B8ahutj6r+jK22vHQtuIRSW3eWXXS847gGqz1vduBY+3yj49lpd7TCl+jc8ZjRI6S hWWluzSKy8T4yi9dG+crGk09JdBnsYBNv9/Bdtp7CNSZYTvG8M5RppeQXL4Ni2AgBg/D qWNeC8vWYAZqszufWgc9tO0Ba+jEvammsZSGpa0ToTUTLDfSyhI5PdYW6xB6g1+/uoZf gPXOorJuXOiA7k8d0Hj4X7faaFDUt+5hI42PVo/kR3D7P+TuMx8EZF3Rx2+jW5kVAsCR helTHOY+R+vqyvoS287fFF9yT3ju5BHxG4ClFIwIVMN1c4Ll1LiDf/4AopEmgfVP60Ls st7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 2-20020a0566380a8200b00321244b1e13si2184026jas.84.2022.03.25.08.06.57; Fri, 25 Mar 2022 08:07:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357639AbiCYCFJ (ORCPT + 99 others); Thu, 24 Mar 2022 22:05:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237272AbiCYCFI (ORCPT ); Thu, 24 Mar 2022 22:05:08 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3BC26579A for ; Thu, 24 Mar 2022 19:03:34 -0700 (PDT) Received: from kwepemi500015.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KPlhQ2tjHzfZg5; Fri, 25 Mar 2022 10:01:58 +0800 (CST) Received: from huawei.com (10.175.127.227) by kwepemi500015.china.huawei.com (7.221.188.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 25 Mar 2022 10:03:32 +0800 From: Zheng Bin To: , , , , , , CC: , Subject: [PATCH v2 -next] drm/vc4: Fix build error when CONFIG_DRM_VC4=y && CONFIG_RASPBERRYPI_FIRMWARE=m Date: Fri, 25 Mar 2022 10:18:31 +0800 Message-ID: <20220325021831.2812735-1-zhengbin13@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500015.china.huawei.com (7.221.188.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_DRM_VC4=y, CONFIG_RASPBERRYPI_FIRMWARE=m, CONFIG_COMPILE_TEST=n, bulding fails: drivers/gpu/drm/vc4/vc4_drv.o: In function `vc4_drm_bind': vc4_drv.c:(.text+0x320): undefined reference to `rpi_firmware_get' vc4_drv.c:(.text+0x320): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `rpi_firmware_get' vc4_drv.c:(.text+0x34c): undefined reference to `rpi_firmware_property' vc4_drv.c:(.text+0x34c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `rpi_firmware_property' vc4_drv.c:(.text+0x354): undefined reference to `rpi_firmware_put' vc4_drv.c:(.text+0x354): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `rpi_firmware_put' Make DRM_VC4 depends on RASPBERRYPI_FIRMWARE || COMPILE_TEST to fix this. Fixes: c406ad5e4a85 ("drm/vc4: Notify the firmware when DRM is in charge") Reported-by: Hulk Robot Signed-off-by: Zheng Bin --- v2: follow Maxime's advise, add RASPBERRYPI_FIRMWARE as an additional depends drivers/gpu/drm/vc4/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig index de3424fed2fc..92d74ba7c449 100644 --- a/drivers/gpu/drm/vc4/Kconfig +++ b/drivers/gpu/drm/vc4/Kconfig @@ -2,6 +2,7 @@ config DRM_VC4 tristate "Broadcom VC4 Graphics" depends on ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST + depends on RASPBERRYPI_FIRMWARE || COMPILE_TEST depends on DRM depends on SND && SND_SOC depends on COMMON_CLK -- 2.31.1