Date: Mon, 26 Feb 2007 17:08:56 +0100
From: Bernhard Walle <bwalle@suse.de>
To: linux-kernel@vger.kernel.org
Subject: GFP_DMA in sd_revalidate_disk
Message-ID: <20070226160856.GA19701@strauss.suse.de>
Mail-Followup-To: linux-kernel@vger.kernel.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 721
Lines: 27

Hello,

[since I got no reply in linux-scsi, I'll try here]

Is GFP_DMA really needed in sd_revalidate_disk() in every circumstances?
That's the code:

    buffer = kmalloc(SD_BUF_SIZE, GFP_KERNEL | __GFP_DMA);
    if (!buffer) {
        printk(KERN_WARNING "(sd_revalidate_disk:) Memory allocation "
               "failure.\n");
        goto out;
    }

Or should could the check (sdp->host->unchecked_isa_dma ? __GFP_DMA : 0)
applied here, too?

Thanks!


Regards,
Bernhard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/