Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <21ebdc8c-ddf8-cd0a-b93c-5d5dd74a9a84@kernel.org>
Date:   Wed, 23 Mar 2022 20:32:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [GIT PULL] tracing/rtla: Updates to the RTLA tool
Content-Language: en-US
To:     Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20220321103035.564a1df5@gandalf.local.home>
 <CAHk-=whxmA86E=csNv76DuxX_wYsg8mW15oUs3XTabu2Yc80yw@mail.gmail.com>
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <CAHk-=whxmA86E=csNv76DuxX_wYsg8mW15oUs3XTabu2Yc80yw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/23/22 19:15, Linus Torvalds wrote:
> On Mon, Mar 21, 2022 at 7:30 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>>
>> I'm sending this as a separate pull request from my normal tracing tree, as
>> it had dependencies to commits in your tree but not in my development
>> branch. As it only affects the tools/ directory, I kept it separate as it
>> has no changes to the kernel itself.
> 
> Yes, please keep the tooling updates separate from the kernel ones,
> the way we now for some time have for the perf tooling too.
> 
> That said, mentioning the perf tools, I wish the tracing tools would
> do a bit more package checking and helpful error messages too, rather
> than just fail with
> 
>     fatal error: tracefs.h: No such file or directory
> 
> when (presumably) libtracefs and friends are needed.
> 
> Hmm?

Yes, we need to improve the Makefile.

It depends on procps-ng-devel and python3-docutils packages and the latest
libtracefs (1.3) and libtraceevent (1.5). There is info about it in the README,
but we definitely need to improve the Makefile... I will prioritize that.

-- Daniel
>               Linus