Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: q2CksHX8FQexu2ifZ65exHHX71tiTaqY9oYllmW/mILyf0OO3MVR1giHuIoCmC5cGBspzd47xr
 +Fxv8Zv9WHZNsy6NRywW/1SVDTR8DLPnYDhSpk7t0O/ZTz90b5OQawhtlBoca3Am3QwT4z8ix+
 Q6ltaA4aVOFiaT27RggTZs330zTwkHd7RUS6OJaQTBXL1YYCY8i8EFvSnN+oz1wibfAyyjEJlN
 Oj2pc3X0NSQwVUNpq+CM5B/o7COHGsxHPKlaF30cx9MCugQ91qJeWE1QBULWknCRmprg5/edln
 +gK6ugzSXRrvFEZU4wn7bLQs
IronPort-SDR: osmz7XER5r+emgvnIMkbLR6zXpVAG2+oZ+3nl83uL+BBfLpB5nae2uzcRpmD3EP/+/l2JqZ44V
 AJ4ip0A1gPYfStKPKRRhLE2hHsbEVHOKzAcHe+NrrGOXMUCrAfPTgss55rseOw+fGwfOBqFmpS
 Or6CTeCTv51EqtNNtQ/7LlnUDx76ESadSspnz4O29MR/ILn5KkM7LS/5l/S8GdOLDtngTqAmym
 9k4XhvZVMR1Kag6zWNsad7jwSSWFTefruKPKmbZL/NN46lBc3Xt9ND+3FkTu9up3J7a3iAc3Uu
 JsM=
WDCIronportException: Internal
Message-ID: <aa410785-b9db-cb97-2fea-f24336472f98@opensource.wdc.com>
Date:   Thu, 24 Mar 2022 13:14:47 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH] ata: libata-core: fix "it's" typos
Content-Language: en-US
To:     Diego Viola <diego.viola@gmail.com>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        corbet@lwn.net
References: <20220323054001.17344-1-diego.viola@gmail.com>
 <ac99cc8e-11c2-d96b-9ce1-ce5618b7b378@opensource.wdc.com>
 <CA+ToGPH+FQ-6QM6MWt6Zoe_pTyL6LTn9-=-694f7xLkSVCCr1Q@mail.gmail.com>
 <641a417b-acac-6b0f-c330-b94b6ed97b99@opensource.wdc.com>
 <CA+ToGPEAhWDwFLNHqXvtuumvdLQb=kzme7fdrgBfb4zojVvDNQ@mail.gmail.com>
 <a030b9b2-d94f-ed62-60bf-cc629da3e944@opensource.wdc.com>
 <CA+ToGPGVdwXgWTZFa24PDMkpXrVrpM48WAxR4U6d4D9t-k=nJQ@mail.gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <CA+ToGPGVdwXgWTZFa24PDMkpXrVrpM48WAxR4U6d4D9t-k=nJQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/23/22 17:44, Diego Viola wrote:
> On Wed, Mar 23, 2022 at 5:17 AM Damien Le Moal
> <damien.lemoal@opensource.wdc.com> wrote:
>>
>> On 3/23/22 16:24, Diego Viola wrote:
>>> On Wed, Mar 23, 2022 at 2:53 AM Damien Le Moal
>>> <damien.lemoal@opensource.wdc.com> wrote:
>>>>
>>>> On 3/23/22 14:52, Diego Viola wrote:
>>>>> On Wed, Mar 23, 2022 at 2:45 AM Damien Le Moal
>>>>> <damien.lemoal@opensource.wdc.com> wrote:
>>>>>>
>>>>>> On 3/23/22 14:40, Diego Viola wrote:
>>>>>>> Use the contraction "it's" instead of the possessive form "its".
>>>>>>
>>>>>> Well, while at it, let's use proper formal written English, so:
>>>>>> s/it's/it is
>>>>>> s/isn't/is not
>>>>>
>>>>> Fine with me, do you want me to send you another patch with those changes?
>>>>
>>>> Yes please.
>>>
>>> I sent a v2 patch changing those things you pointed out, however, the
>>> whole comment[0] looks informal "But wait.. there's more" and I don't
>>> think replacing "it's" with "it is" achieves a lot in this case.
>>
>> :)
>>
>> Indeed. Do you want it in or can I drop it ?
> 
> Given that the language is mostly informal, I'd rather see the first
> patch applied (if that is OK with you). However, I agree with you that
> it would be nice to see formal language used, I just don't think I'm
> the right person to change all the comments in that file. :(

OK. I will look at it.

> 
> Thanks,
> Diego


-- 
Damien Le Moal
Western Digital Research