Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6dbeda18-a11c-609d-7a8f-bf2e6f27aea7@kernel.org>
Date:   Wed, 23 Mar 2022 09:37:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
From:   Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset
 driver
Content-Language: en-US
To:     =?UTF-8?B?cWluamlhblvopoPlgaVd?= <qinjian@cqplus1.com>
Cc:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "maz@kernel.org" <maz@kernel.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        Rob Herring <robh@kernel.org>
References: <cover.1647928315.git.qinjian@cqplus1.com>
 <55db801055793f43678e902395913330ecb8fbbf.1647928316.git.qinjian@cqplus1.com>
 <a7194fbf-8423-9b49-1443-68dd33e23783@kernel.org>
 <678d1f84d9d240b9983f9d3b82db17d4@cqplus1.com>
In-Reply-To: <678d1f84d9d240b9983f9d3b82db17d4@cqplus1.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 23/03/2022 02:54, qinjian[覃健] wrote:
>>> +examples:
>>> +  - |
>>> +    rstc: reset@9c000054 {
>>> +      compatible = "sunplus,sp7021-reset";
>>> +      #reset-cells = <1>;
>>> +      reg = <0x9c000054 0x28>;
>>
>> I asked you to put the reg after compatible in all DTS code and
>> examples. If you do not agree with a comment, please respond. Ignoring
>> it is not cooperative.
>>
> 
> Your  reply: https://lore.kernel.org/all/d3ac3e2f-71fd-b2b4-7c7e-bb43c681d14e@canonical.com/
>>> +  - |
>>> +
>>> +    clkc: clock-controller@9c000000 {
>>> +      compatible = "sunplus,sp7021-clkc";
>>> +      #clock-cells = <1>;
>>> +      reg = <0x9c000000 0x280>;
>>
>> In DTS code, please put reg after compatible. In all your examples and
>> DTS patches.
>>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> I see your review-tag. So, I misunderstand your comments.
> Did you means 'reg' must directly after the 'compatible', like this?
>     clkc: clock-controller@9c000000 {
>       #clock-cells = <1>;
>       compatible = "sunplus,sp7021-clkc";
>       reg = <0x9c000000 0x280>;

You moved now compatible so not. First goes compatible, then goes reg.

clock-controller@.... {
  compatible = ....;
  reg = ...;
  here goes the rest;
}

My review tag was conditional because I asked to change the code. Such
review tag should be used by you if you implement what I asked for.

Best regards,
Krzysztof