Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2075685pxb; Fri, 25 Mar 2022 10:38:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMGsflDxGE8lAiO8resPMLTg7S9D45ytN8YNMHdd0jTS+q6S6H7biczcwzaeS57gfnvydJ X-Received: by 2002:a65:674b:0:b0:381:6565:26fc with SMTP id c11-20020a65674b000000b00381656526fcmr529262pgu.618.1648229915897; Fri, 25 Mar 2022 10:38:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648229915; cv=none; d=google.com; s=arc-20160816; b=vgGDicJA6k46vORsK6DgemM1bgqgO4HsmuuU8so3Kd0X8Jo2cMMW2abJOcBD2A7ulp 3ssV5fjPkMrg7pWqb/6knXJV+r4+dCGP/qkyXLqn/+x1HWXBJNRyLQeE4xSe3bsQ9EgF JARtS1f/URhZKrXIsyr8Lw/2HSUBOij5Zq4Kk43otWbLs9pnr0BJmjASp8sCJC1cQ7rt K5E3w0dQC3OqknGItCwUhttZY+ZYR9VWnzUMaXxK6wqqsGQd83mP6iHDLSNscutnXFWA MfM2rLAr5iLffj1OFSzVx5+boKPDJF5dsKrRWG4t4XJcJfFgZGt0S1ZK2i8iwuxTBTH6 HKIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=0kOdsZwrQL1XfPdlkXlj/9Xa+AzVdDQNepJd8esNMSA=; b=e9ooqIbb7tuUvA2hNDtE9TFDQh/lOIh4oXIUfw64DJC5hlRPiG4NJywifClBtEzUej bnrOHhaRGGqwuCGg/H9uZmY5RiB1JHFBU4dAAokljQblyRYJt9t6Cub9aRZQLlYYdn6o cWAdoc4+u2qa9ozYyJuSlg+/eT1RuqJh+ZT57iDjj0fMBQNYc0/36ySmydcr7DfK6b4K MbGIWQspJ3p12hZdsfI3SkdthoGYDvoGIXSHYKOnRBFiA+rFBeLcSjA0LkmmONXpFwj5 osCdQAlFDzPSabz+DFcbCAMW+2sl0tu9QmN+6WRYBx764shiWzvFv1xouLMArR1bokvk qc1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="RH/4wmzM"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u128-20020a626086000000b004fa3a8dff4esi3225946pfb.5.2022.03.25.10.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 10:38:35 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="RH/4wmzM"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 19A7B1179A3; Fri, 25 Mar 2022 10:26:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376998AbiCYQve (ORCPT + 99 others); Fri, 25 Mar 2022 12:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356491AbiCYQvd (ORCPT ); Fri, 25 Mar 2022 12:51:33 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EF7BC12CF; Fri, 25 Mar 2022 09:49:59 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id p8so6879533pfh.8; Fri, 25 Mar 2022 09:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0kOdsZwrQL1XfPdlkXlj/9Xa+AzVdDQNepJd8esNMSA=; b=RH/4wmzM1N3goA6fDZmEOIqtcFbnwVj6hl5sryG3LVcXbBaAg9OcTs0/mLXdIkBzIN KoStwbD4ZY9nNn9EgZkemVf1m6GGtdopt2bFVM4viCuyBJRomC+f7npkNtNB0fCB/KB4 gvoZNLNQUKQI2VLfiNYQ7/C4/QdOLqYznSm6nM2jR3aMfDDTntAeCmuvwIezXqUbDHfy pBQad0mQ0n3cJseK4nbrh610UoIoqXdFPu9AwgRu5nm7mLEzdEkSzIUUkM81ksnI6MLx +vsIvtoxlIWvxM8xyEhQmDGBITfT4k6qkRN7BRv0aH/wP+jQLLWc17mqgQCJzVz+mHc9 55PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0kOdsZwrQL1XfPdlkXlj/9Xa+AzVdDQNepJd8esNMSA=; b=YRXWdSBiWJT2UGH0wzFFudCzNVApWWKeLF5vXeNRlyv0IVmrd2cOUhyLNeiN8nrhSS IKpaYOlCSgN2BZKhvnqhyK6FoSE23FW3/IUi2CKJ3C/G17fzyfuArcyxMNPQ/aQu7HG5 1UP8gZptuaegkpbFDcvcA5LxSkAn5eLYglDCCMIT8adIk4QVisA2y9ErFxrexy0asgZF i4/IvyviY8+4bBvX6CkIzmM2tBxEEOTf3+WDjX4A325AOp0Q6uBAIOqx3M6p/dZU3rY3 kjkOKpMKf4DoXDunzhZxoDNM2FMCRVevw/zRpaHmBX02oSEaNmw9ZdH2SBIk6OlgnorB Wb7Q== X-Gm-Message-State: AOAM531rRkfbZBsz0l46Lub7HFPl2A3jdewE9x/W+aQJGrV7g6gAZBn0 KFgeTgsdC/0KYA7qHgr+oKeb2hUbnX7GOkfRTWU= X-Received: by 2002:a63:c00c:0:b0:37c:942e:6c3c with SMTP id h12-20020a63c00c000000b0037c942e6c3cmr398099pgg.336.1648226998607; Fri, 25 Mar 2022 09:49:58 -0700 (PDT) MIME-Version: 1.0 References: <164821817332.2373735.12048266953420821089.stgit@devnote2> In-Reply-To: From: Alexei Starovoitov Date: Fri, 25 Mar 2022 09:49:47 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2 0/4] kprobes: rethook: x86: Replace kretprobe trampoline with rethook To: Peter Zijlstra Cc: Masami Hiramatsu , Alexei Starovoitov , Andrii Nakryiko , X86 ML , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Dan Carpenter , kernel-janitors@vger.kernel.org, Steven Rostedt , Jiri Olsa , bpf , LKML Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 25, 2022 at 7:43 AM Peter Zijlstra wrote: > > On Fri, Mar 25, 2022 at 11:22:53PM +0900, Masami Hiramatsu wrote: > > > Masami Hiramatsu (3): > > kprobes: Use rethook for kretprobe if possible > > rethook: kprobes: x86: Replace kretprobe with rethook on x86 > > x86,kprobes: Fix optprobe trampoline to generate complete pt_regs > > > > Peter Zijlstra (1): > > Subject: x86,rethook: Fix arch_rethook_trampoline() to generate a complete pt_regs > > You fat-fingered the subject there ^ > > Other than that: > > Acked-by: Peter Zijlstra (Intel) > > Hopefully the ftrace return trampoline can also be switched over.. Thanks Peter. What's an ETA on landing endbr set? Did I miss a pull req? I see an odd error in linux-next with bpf selftests which may or may not be related. Planning to debug it when everything settles in Linus's tree. Masami, could you do another respin? Also do you mind squashing patches 2,3,4 ? It's odd to have the same lines of code patched up 3 times. Just do it right once.